Bug 9653

Summary:	Bad markup in XQueryColor.3x
Product:	xorg	Reporter:	Eric S. Raymond <esr>
Component:	Lib/Xlib	Assignee:	Xorg Project Team <xorg-team>
Status:	RESOLVED FIXED	QA Contact:	Xorg Project Team <xorg-team>
Severity:	normal
Priority:	high
Version:	unspecified
Hardware:	x86 (IA32)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:

Description Eric S. Raymond 2007-01-14 10:41:47 UTC

Problems with XQueryColor.3x:

1. Use of low-level troff hackery to set special indents or breaks can't
be translated. The page will have rendering faults in HTML, and
probably also under third-party man page browsers such as Xman,
Rosetta, and the KDE help browser.  This patch eliminates .br, .ta, .ti
and .in in favor of requests like .nf/.fi, and .RS/.RE that have
structural translations.

2. TBL markup not used where it should be.  Tables stitched together
with .ta requests can't be lifted to DocBook and will often
choke third-party viewers such as TKMan, XMan, Rosetta, etc.

--- XQueryColor.3x-orig	2007-01-14 02:22:42.000000000 -0500
+++ XQueryColor.3x	2007-01-14 02:24:15.000000000 -0500
@@ -276,16 +276,13 @@
 The syntax is an initial sharp sign character followed by
 a numeric specification, in one of the following formats:
 .LP
-.\" Start marker code here
-.Ds 0
-.TA 2i
-.ta 2i
+.TS
+l l.
 \&#RGB	(4 bits each)
 \&#RRGGBB	(8 bits each)
 \&#RRRGGGBBB	(12 bits each)
 \&#RRRRGGGGBBBB	(16 bits each)
-.De
-.\" End marker code here
+.TE
 .LP
 The R, G, and B represent single hexadecimal digits.
 When fewer than 16 bits each are specified,

Comment 1 Daniel Stone 2007-02-27 01:35:44 UTC

Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.

Comment 2 Alan Coopersmith 2007-08-21 15:33:05 UTC

Thanks for the patch - fix committed to git master:

commit 2db713252090cae08f0200fecad4fc25fb64c8b1
Author: Eric S. Raymond <esr@thyrsus.com>
Date:   Sun Jan 14 10:40:00 2007 -0800

    Bug #9653: Bad markup in XQueryColor.3x
    
    X.Org Bugzilla #9653 <https://bugs.freedesktop.org/show_bug.cgi?id=9653>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.