Bug 96537

Thanks, committed

The patch, from 2016, credits the layout to Mart Lubbers, but as far as I know this xkb layout was created in April 2007 by Oleg Zalizniak.  (In 2009 Oleg submitted it to the Ubuntu bug tracker at <https://bugs.launchpad.net/ubuntu/+source/xkeyboard-config/+bug/319376>.)

I think it's unlikely that Mart and Oleg independently come up with the exact same layout (particularly given the unusual dead-key accents).  If Mart simply copied Oleg's layout and put his name on it, then the attribution comment in the file should be changed to give Oleg due credit.

Oh, I see from the actual commit at <https://cgit.freedesktop.org/xkeyboard-config/commit/?id=bb94337060a07d97d8829a6b34c7152bab66da27> now that Mart's inline comment from his patch didn't get included, though Sergey did credit Mart as the author of the commit.  Again, if this is really Oleg's layout, then the commit author metadata should be changed.  I've e-mailed Oleg to notify him about this.

The original code was from Oleg but I've added the xml rules and merged it into the codebase. It would be appropriate to add him.
Mart

Created attachment 128672 [details]
signature.asc

The original code was from Oleg but I did the rules and merged it into the
codebase. It would be appropriate to add Oleg as well.

Best,
Mart

On Wed, Dec 28, 2016 at 05:19:07PM +0000, bugzilla-daemon@freedesktop.org wrote:
> Comment # 3 on bug 96537 from Tristan Miller
> 
> Oh, I see from the actual commit at
> <https://cgit.freedesktop.org/xkeyboard-config/commit/?id=bb94337060a07d97d8829a6b34c7152bab66da27>
> now that Mart's inline comment from his patch didn't get included, though
> Sergey did credit Mart as the author of the commit.  Again, if this is really
> Oleg's layout, then the commit author metadata should be changed.  I've
> e-mailed Oleg to notify him about this.
> 
> ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
> You are receiving this mail because:
> 
>   • You reported the bug.
>

sorry you got me confused - what should I do with the signature file?

Created attachment 128815 [details] [review]
Patch to restore Oleg Zalizniak's credit line

(In reply to Sergey V. Udaltsov from comment #6)
> sorry you got me confused - what should I do with the signature file?

Nothing.  Mart replied to a Bugzilla notification by e-mail, and Bugzilla misinterpreted his OpenPGP signature as an attachment.  The only action required from you is to credit Oleg Zalizniak for the phonetic_dvorak layout in symbols/ru, and possibly also change the Git author metadata for https://cgit.freedesktop.org/xkeyboard-config/commit/?id=bb94337060a07d97d8829a6b34c7152bab66da27 to "Oleg Zalizniak <ramaloke@gmail.com>".

For the first action item I attach a patch.  All this does is to replace Oleg's credit from Attachment 22256 [details] to Bug 19749, which Mart had stripped out and replaced with a credit to himself.

Oh, and Mart, if there is any other code you contributed to this project (or any others, for that matter) where you removed the original author's name and replaced it with your own, now would be a good time for you to submit some patches to correct these problems.

Thanks, credits fixed