| Summary: | PDFDoc::saveIncrementalUpdate() saves a new version of document regardless if the document is actually modified | ||
|---|---|---|---|
| Product: | poppler | Reporter: | Jakub Alba <jakubalba> |
| Component: | general | Assignee: | poppler-bugs <poppler-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | jakubalba |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
proposed patch
[PATCH] Fix PDFDoc::saveIncrementalUpdate()'s detection of document being modified [PATCH] PDFDoc::saveIncrementalUpdate: don't check if there are updated entries [PATCH] Fix PDFDoc::saveIncrementalUpdate()'s detection of document being modified [PATCH] PDFDoc::saveIncrementalUpdate: don't check if there are updated entries |
||
|
Description
Jakub Alba
2016-06-17 11:40:17 UTC
Created attachment 124571 [details] [review] proposed patch Created attachment 125254 [details] [review] [PATCH] Fix PDFDoc::saveIncrementalUpdate()'s detection of document being modified Added a comment explaining why it should be 1, not 0. Created attachment 125580 [details] [review] [PATCH] PDFDoc::saveIncrementalUpdate: don't check if there are updated entries Or we can stop checking the number of updated entries, since the only caller already checks if the document is modified. Choice is yours. Created attachment 127478 [details] [review] [PATCH] Fix PDFDoc::saveIncrementalUpdate()'s detection of document being modified Created attachment 127479 [details] [review] [PATCH] PDFDoc::saveIncrementalUpdate: don't check if there are updated entries I've updated my name and e-mail in the commit author info. Pushed the one with the "fixed" check |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.