Bug 96647

Summary: [SNB,CTS] es3-cts.gtf.gl3tests.npot_textures.npot_tex_image regression
Product: Mesa Reporter: Mark Janes <mark.a.janes>
Component: Drivers/DRI/i965Assignee: Jason Ekstrand <jason>
Status: RESOLVED FIXED QA Contact: Intel 3D Bugs Mailing List <intel-3d-bugs>
Severity: normal    
Priority: medium    
Version: git   
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 98335    

Description Mark Janes 2016-06-23 02:58:09 UTC
Bisected to:
Author:     Jason Ekstrand <jason@jlekstrand.net>
i965: Drop the maximum 3D texture size to 512 on Sandy Bridge

The RenderTargetViewExtent field of RENDER_SURFACE_STATE is supposed to be
set to the depth of a 3-D texture when rendering.  Unfortunatley, that
field is only 9 bits on Sandy Bridge and prior so we can't actually bind
a 3-D texturing for rendering if it has depth > 512.  On Ivy Bridge, this
field was bumpped to 11 bits so we can go all the way up to 2048.  On Iron
Lake and prior, we don't support layered rendering and we use OffsetX/Y
hacks to render to particular layers so 2048 is ok there too.

Signed-off-by: Jason Ekstrand <jason@jlekstrand.net>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Cc: "11.1 11.2 12.0" <mesa-stable@lists.freedesktop.org>

/tmp/build_root/m64/bin/cts/glcts --deqp-case=ES3-CTS.gtf.GL3Tests.npot_textures.npot_tex_image
dEQP Core GL-CTS-2.0 (0x0052484b) starting..
  target implementation = 'intel-gbm'

Test case 'ES3-CTS.gtf.GL3Tests.npot_textures.npot_tex_image'..
ERROR:npot_tex_image: GL_INVALID_VALUE, internalformat: GL_LUMINANCE, level: 2, target: -

  Fail (Fail)


Test run totals:
  Passed:        0/1 (0.00%)
  Failed:        1/1 (100.00%)
  Not supported: 0/1 (0.00%)
  Warnings:      0/1 (0.00%)
Comment 1 Jason Ekstrand 2016-06-23 03:23:40 UTC
This bug was more-or-less expected.  Really, it's a CTS bug because the CTS assumes that you can create 3-D textures larger than 512 without checking.  More specifically, it tries to call glTexImage with level 2 and a size of 11x131x1.  That said, I'm going to leave this open as a reminder that we should really try and bump the max 3-D texture size back up on Sandy Bridge when we have the chance.
Comment 2 Mark Janes 2016-10-19 22:32:10 UTC
Can this bug be fixed, or should it be closed?
Comment 3 Kenneth Graunke 2016-10-24 23:18:49 UTC
Fixed by:

commit 24be6306609179efddfb7e5cc6ec5d6a335c9b88
Author: Jason Ekstrand <jason.ekstrand@intel.com>
Date:   Mon Sep 12 08:18:53 2016 -0700

    Revert "i965: Drop the maximum 3D texture size to 512 on Sandy Bridge"

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.