| Summary: | Add a Game Boy Color MIME type | ||
|---|---|---|---|
| Product: | shared-mime-info | Reporter: | Adrien Plazas <kekun.plazas> |
| Component: | freedesktop.org.xml | Assignee: | Shared Mime Info group <shared_mime_info> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | bugzilla, fitojb, kekun.plazas |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | Add a Game Boy Color MIME type | ||
|
Description
Adrien Plazas
2016-08-01 08:13:56 UTC
Created attachment 125455 [details] [review] Add a Game Boy Color MIME type Allow to disambiguate Game Boy Color ROMs from Game Boy ones. Comment on attachment 125455 [details] [review] Add a Game Boy Color MIME type Review of attachment 125455 [details] [review]: ----------------------------------------------------------------- Rest looks fine. ::: freedesktop.org.xml.in @@ +2110,3 @@ > </magic> > <glob pattern="*.gb"/> > + <glob pattern="*.sgb"/> Please add that glob separately. Comment on attachment 125455 [details] [review] Add a Game Boy Color MIME type Review of attachment 125455 [details] [review]: ----------------------------------------------------------------- ::: freedesktop.org.xml.in @@ +2111,5 @@ > <glob pattern="*.gb"/> > + <glob pattern="*.sgb"/> > + </mime-type> > + <mime-type type="application/x-gameboy-color-rom"> > + We don't need that linefeed, and it adds trailing whitespace anyway. Comment on attachment 125455 [details] [review] Add a Game Boy Color MIME type Review of attachment 125455 [details] [review]: ----------------------------------------------------------------- ::: freedesktop.org.xml.in @@ +2110,3 @@ > </magic> > <glob pattern="*.gb"/> > + <glob pattern="*.sgb"/> I didn't add it, it was lower in the list of original Game Boy globs, after the Game Boy Color ones. (In reply to Adrien Plazas from comment #4) > Comment on attachment 125455 [details] [review] [review] > Add a Game Boy Color MIME type > > Review of attachment 125455 [details] [review] [review]: > ----------------------------------------------------------------- > > ::: freedesktop.org.xml.in > @@ +2110,3 @@ > > </magic> > > <glob pattern="*.gb"/> > > + <glob pattern="*.sgb"/> > > I didn't add it, it was lower in the list of original Game Boy globs, after > the Game Boy Color ones. The *linefeed*, not the glob. You're commenting on the line above the linefeed that you most definitely added in the patch. Attachment 125455 [details] pushed as eeb5c33 - Add a Game Boy Color MIME type
Pushed after removing the linefeed
|
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.