| Summary: | [BDW] GL45-CTS.texture_cube_map_array.sampling asserts inside brw_fs.cpp | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | Ian Romanick <idr> |
| Component: | Drivers/DRI/i965 | Assignee: | Ian Romanick <idr> |
| Status: | RESOLVED FIXED | QA Contact: | Intel 3D Bugs Mailing List <intel-3d-bugs> |
| Severity: | normal | ||
| Priority: | medium | CC: | currojerez, mark.a.janes |
| Version: | git | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
|
Description
Ian Romanick
2016-08-09 20:20:02 UTC
Curro: git-blame says you wrote the assertion. Could you take a look at this? (In reply to Ian Romanick from comment #1) > Curro: git-blame says you wrote the assertion. Could you take a look at > this? I've been trying to reproduce this today, but the test passes for me... Are you running this on mesa master or do you have additional changes applied? (In reply to Francisco Jerez from comment #2) > (In reply to Ian Romanick from comment #1) > > Curro: git-blame says you wrote the assertion. Could you take a look at > > this? > > I've been trying to reproduce this today, but the test passes for me... Are > you running this on mesa master or do you have additional changes applied? I started looking at this one because Mark had already observed a crash in this test on the CI. Were you perhaps running a release build without assertions? :) What platform are you on? I and the CI saw this on BDW. It looks like the CI does not encounter this on SKL. Not sure about other platforms. https://github.com/janesma/mesa_jenkins/blob/master/cts-test/bdw.conf https://github.com/janesma/mesa_jenkins/blob/master/cts-test/skl.conf (In reply to Ian Romanick from comment #3) > (In reply to Francisco Jerez from comment #2) > > (In reply to Ian Romanick from comment #1) > > > Curro: git-blame says you wrote the assertion. Could you take a look at > > > this? > > > > I've been trying to reproduce this today, but the test passes for me... Are > > you running this on mesa master or do you have additional changes applied? > > I started looking at this one because Mark had already observed a crash in > this test on the CI. Were you perhaps running a release build without > assertions? :) What platform are you on? I and the CI saw this on BDW. It > looks like the CI does not encounter this on SKL. Not sure about other > platforms. > > https://github.com/janesma/mesa_jenkins/blob/master/cts-test/bdw.conf > https://github.com/janesma/mesa_jenkins/blob/master/cts-test/skl.conf Right, I was testing on SKL which doesn't crash at that point, I can reproduce the crash by running it on BDW. I believe the reason why it works on SKL is that it now uses the TXL_LZ message instead of TXL, which reduces the payload size by two preventing it from exceeding the sampler payload limit. I believe on Gen7-8 platforms sampling from a cubemap array with shadow comparitor on a non-FS stage has been broken since the FS back-end supports non-FS stages... I'll send a patch. That turned out to be the tip of the iceberg... The TEX, TXL and TXB instructions were all trying to use SIMD16 for shadow cubemap arrays exceeding the maximum message size supported by the sampler, and TG4_OFFSET was falling back to SIMD8 incorrectly in some cases. It should be fixed by this series I just sent to the mailing list: https://lists.freedesktop.org/archives/mesa-dev/2016-August/125922.html Should be fixed in master now. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.