Bug 97300

Created attachment 125810 [details] [review]
glamor: Add declaration of "pos" for GLSL 1.20 variant

Does this patch fix the problem?

I don't know GLSL or Xorg well enough to answer this.

I don't have any way to trigger the crash so I can't answer your question definitively.

That said, it seems like it would fix the crash but:

Did you mean to change how gl_Position is computed?

The code from the crash makes me think that fill_pos should be based on glyph_pos instead of pos?

I do have a way to trigger the crash in XFCE, by trying to open the Screensaver settings, and since both are user Debian, it seems like the same bug. I'm trying to get some useful backtrace, but I apparently aren't able to use gdb correctly.

The crash is just an exit with error rather than a segfault or anything that gdb would be useful for.

The error is printed to the Xorg log file, if you are using non-root Xorg that is ~/.local/share/xorg/Xorg.1.log.old (after you log in again), otherwise one of the /var/log/Xorg.*.log* files.

If that's the case, then my output is exactly the same as reporter. Will patch xorg and report the results.

After applying the patch, I can still reproduce the issue. It exits exactly the same way.

(In reply to braiamp from comment #6)
> After applying the patch, I can still reproduce the issue. It exits exactly
> the same way.

Please attach the error output with the patch applied.

[  6431.065] Failed to compile VS: 0:13(43): error: `pos' undeclared
0:13(14): error: operands to arithmetic operators must be numeric
0:13(13): error: operands to arithmetic operators must be numeric

[  6431.072] Program source:
#define ATLAS_DIM_INV 0.000976562500000000
attribute vec2 primitive;
attribute vec2 source;
varying vec2 glyph_pos;
uniform vec2 fill_offset;
uniform vec2 fill_size_inv;
varying vec2 fill_pos;
uniform vec4 v_matrix;
void main() {
       gl_Position.xy = primitive.xy * v_matrix.xz + v_matrix.yw;
       gl_Position.zw = vec2(0.0,1.0);
       glyph_pos = source.xy * ATLAS_DIM_INV;
       fill_pos = (fill_offset + primitive.xy + pos) * fill_size_inv;
}
[  6431.072] (EE) 
Fatal server error:
[  6431.072] (EE) GLSL compile failure
[  6431.072] (EE) 
[  6431.072] (EE) 
Please consult the The X.Org Foundation support 
	 at http://wiki.x.org
 for help. 
[  6431.072] (EE) Please also check the log file at "/var/log/Xorg.0.log" for additional information.
[  6431.072] (EE) 
[  6431.077] (II) AIGLX: Suspending AIGLX clients for VT switch
[  6431.108] (EE) Server terminated with error (1). Closing log file.

Exactly the same.

(In reply to braiamp from comment #8)
> Exactly the same.

That probably means there was a problem applying the patch, and it didn't take effect.

Yes, my mistake. It fixed my problem. Not sure if it's OP problem through. Do I have to report my own bug?

(In reply to braiamp from comment #10)
> Yes, my mistake. It fixed my problem. Not sure if it's OP problem through.
> Do I have to report my own bug?

No, it's the same problem. Thanks for testing the fix, I submitted it for review: https://patchwork.freedesktop.org/patch/105827/

commit be334f42a198a25e817e6dab43dd0e30aa1cd4f8
Author: Michel Dänzer <michel.daenzer@amd.com>
Date:   Thu Aug 18 09:40:34 2016 +0900

    glamor: Declare "pos" in the composite glyph GLSL 1.20 vertex shader