Bug 97368

Summary:

ASUS X450LCP brighness hot keys aren't working

Product:

DRI

Reporter:

Marcos Souza <marcos.souza.org>

Component:

DRM/Intel

Assignee:

Intel GFX Bugs mailing list <intel-gfx-bugs>

Status:

CLOSED FIXED

QA Contact:

Intel GFX Bugs mailing list <intel-gfx-bugs>

Severity:

normal

Priority:

medium

CC:

intel-gfx-bugs

Version:

XOrg git

Hardware:

Other

OS:

All

URL:

https://bugzilla.kernel.org/show_bug.cgi?id=152091

Whiteboard:

i915 platform:

HSW

i915 features:

display/backlight

Attachments:

Description	Flags
dmesg with drm.debug=0x1e	none

Description Marcos Souza 2016-08-16 15:56:28 UTC

Created attachment 228451 [details]
DMI info

After trying to follow instructions from http://hansdegoede.livejournal.com/13889.html, I could check it didn't worked.

The only kernel parameter that made it work was "acpi_osi=".

I tried to try different parameters, but none of them worked. When using "acpi_osi=", /sys/class/backlight had two acpi_video0 entries:
[marcos@xfiles ~]$ ls /sys/class/backlight/
acpi_video0  acpi_video1  intel_backlight

There is something or someplace I should take a look in the source code?

Thanks!

Comment 1 yann 2016-08-23 14:49:39 UTC

Marcos, please add drm.debug=0x1e and attach kernel log (ie dmesg).

Comment 2 Marcos Souza 2016-08-23 16:06:12 UTC

(In reply to yann from comment #1)
> Marcos, please add drm.debug=0x1e and attach kernel log (ie dmesg).

Hi Yann,

while testing new kernel 4.8-rc2, it working now, although I'm having smoe problem with suspend/resume (which is getting stuck).

Even the Fn+F7 hot key is working (Turn the screen off).

So, should I close it now, or wait for 4.8 to being released?

Comment 3 yann 2016-08-23 16:51:26 UTC

(In reply to Marcos Souza from comment #2)
> (In reply to yann from comment #1)
> > Marcos, please add drm.debug=0x1e and attach kernel log (ie dmesg).
> 
> Hi Yann,
> 
> while testing new kernel 4.8-rc2, it working now, although I'm having smoe
> problem with suspend/resume (which is getting stuck).
> 
> Even the Fn+F7 hot key is working (Turn the screen off).
> 
> So, should I close it now, or wait for 4.8 to being released?

Hi Marcos, I think this is fair to close it now. If later, it is occurring again, please reopen and add "Regression" as tag in the title.
Thanks :)

Comment 4 Marcos Souza 2016-08-24 15:49:30 UTC

It seems 4.8-rc2 has fixed this problem, although I'm facing some problem wrt suspend/resume.

Comment 5 Marcos Souza 2016-08-30 00:59:33 UTC

Sorry, trying a new build proved the problem still exists in 4.8-rc4. SO, reopening.

Comment 6 Marcos Souza 2016-08-30 01:00:11 UTC

(In reply to yann from comment #1)
> Marcos, please add drm.debug=0x1e and attach kernel log (ie dmesg).

Sure.

Comment 7 Marcos Souza 2016-09-06 15:33:31 UTC

Created attachment 126249 [details]
dmesg with drm.debug=0x1e

Comment 8 Marcos Souza 2016-10-15 03:43:47 UTC

(In reply to yann from comment #3)
> (In reply to Marcos Souza from comment #2)
> > (In reply to yann from comment #1)
> > > Marcos, please add drm.debug=0x1e and attach kernel log (ie dmesg).
> > 
> > Hi Yann,
> > 
> > while testing new kernel 4.8-rc2, it working now, although I'm having smoe
> > problem with suspend/resume (which is getting stuck).
> > 
> > Even the Fn+F7 hot key is working (Turn the screen off).
> > 
> > So, should I close it now, or wait for 4.8 to being released?
> 
> Hi Marcos, I think this is fair to close it now. If later, it is occurring
> again, please reopen and add "Regression" as tag in the title.
> Thanks :)

Do you need any more additional info?

Comment 9 Marcos Souza 2016-11-17 20:00:34 UTC

Closing this bug, as Jani's patches are already queued in drm-intel-next-queued[1].

Thanks a lot Jani and yann.

[1] http://www.mail-archive.com/intel-gfx@lists.freedesktop.org/msg104438.html

Comment 10 Jani Nikula 2016-11-18 09:57:01 UTC

Thanks for the followup here, Marcos!

Comment 11 Marcos Souza 2016-11-18 15:47:18 UTC

(In reply to Jani Nikula from comment #10)
> Thanks for the followup here, Marcos!

Hi Jani,

is there a chance to get these patches back to stable? It seems to solve problems in some other Asus laptops: https://bugzilla.kernel.org/show_bug.cgi?id=98931

And, there are a lot of Asus users complaining about the same problem, so this seems to be a good candidate for stable versions.

Thanks for your work :)

Comment 12 Marcos Souza 2016-11-21 10:05:28 UTC

Jani,

One user have tried your patches against kernel 4.8.8, and it worked: https://bugzilla.kernel.org/show_bug.cgi?id=98931#c80

Comment 13 Jani Nikula 2016-11-21 13:05:39 UTC

I first want to make sure these don't regress for some other people before requesting stable backports.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.