Bug 97376

Summary:	Documentation fails to build
Product:	Farstream	Reporter:	Jeremy Bicha <jbicha>
Component:	Core	Assignee:	Olivier Crête <olivier.crete>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Add missing includes to fix docs build Add missing includes to fix docs build

Description Jeremy Bicha 2016-08-17 06:54:13 UTC

On Ubuntu 16.10 (development) farstream 0.8 fails to build because of missing includes in the docs. Full build log at https://launchpad.net/ubuntu/+source/farstream-0.2/0.2.8-1ubuntu1/+build/10625861

Patch attached.

make[4]: Leaving directory '/«PKGBUILDDIR»/docs/libs'
Making all in plugins
make[4]: Entering directory '/«PKGBUILDDIR»/docs/plugins'
  DOC   Introspecting gobjects
farstream-plugins-scan.c: In function 'get_object_types':
farstream-plugins-scan.c:223:12: warning: implicit declaration of function 'fs_rtp_participant_get_type' [-Wimplicit-function-declaration]
     type = fs_rtp_participant_get_type ();
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~
farstream-plugins-scan.c:230:12: warning: implicit declaration of function 'fs_rtp_session_get_type' [-Wimplicit-function-declaration]
     type = fs_rtp_session_get_type ();
            ^~~~~~~~~~~~~~~~~~~~~~~
farstream-plugins-scan.c:237:12: warning: implicit declaration of function 'fs_rtp_stream_get_type' [-Wimplicit-function-declaration]
     type = fs_rtp_stream_get_type ();
            ^~~~~~~~~~~~~~~~~~~~~~
farstream-plugins-scan.c:244:12: warning: implicit declaration of function 'fs_msn_conference_get_type' [-Wimplicit-function-declaration]
     type = fs_msn_conference_get_type ();
            ^~~~~~~~~~~~~~~~~~~~~~~~~~
farstream-plugins-scan.c:251:12: warning: implicit declaration of function 'fs_msn_participant_get_type' [-Wimplicit-function-declaration]
     type = fs_msn_participant_get_type ();
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~

(lt-farstream-plugins-scan:13711): GLib-GObject-WARNING **: cannot register existing type 'FsMsnConference'

(lt-farstream-plugins-scan:13711): GLib-CRITICAL **: g_once_init_leave: assertion 'result != 0' failed
** Message: fs_msn_conference_get_type () didn't return a valid type
Segmentation fault (core dumped)

Comment 1 Jeremy Bicha 2016-08-17 06:55:14 UTC

Created attachment 125836 [details] [review]
Add missing includes to fix docs build

Comment 2 Jeremy Bicha 2016-08-17 07:23:13 UTC

Created attachment 125837 [details] [review]
Add missing includes to fix docs build

Comment 3 Olivier Crête 2016-08-17 07:33:08 UTC

Strange, this has worked without those includes in a long time, but this patch is correct and can,t hurt, so merged it:

commit 1dcbbb07cbc8c3f05e3c86d21713d1a059eb2486
Author: Jeremy Bicha <jbicha@ubuntu.com>
Date:   Wed Aug 17 02:51:38 2016 -0400

    Add missing includes to fix docs build
    
    https://bugs.freedesktop.org/97376

Comment 4 Jeremy Bicha 2016-08-17 12:57:39 UTC

Yeah, it still built on Debian unstable.

Comment 5 Laurent Bigonville 2016-12-18 00:10:25 UTC

Hi,

I added this patch on the top of the debian unstable version and it still FTBFS due to:

farstream-plugins-scan.c: In function 'get_object_types':
farstream-plugins-scan.c:255:12: warning: implicit declaration of function 'fs_msn_participant_get_type' [-Wimplicit-function-declaration]
     type = fs_msn_participant_get_type ();



Adding to the attached patch fixed the FTBFS

+#include "../../gst/fsmsnconference/fs-msn-participant.h"

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.