Bug 97569

Summary: [swrast] piglit getteximage-formats regression
Product: Mesa Reporter: Vinson Lee <vlee>
Component: Drivers/DRI/swrastAssignee: mesa-dev
Status: RESOLVED MOVED QA Contact: mesa-dev
Severity: normal    
Priority: medium CC: kenneth, topi.pohjolainen
Version: 13.0Keywords: bisected, regression
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 98471    

Description Vinson Lee 2016-09-01 21:02:56 UTC
mesa: 72b56e8b1ae34b4c10f822b704521ccd463270b3 (master 12.1.0-devel)


$ ./bin/getteximage-formats -auto
getteximage-formats failure: format: GL_SRGB_EXT, level 1 at pixel(369, 103)
 Expected (0.992157, 0.992157, 0.501961, 1.000000)
	 Found (0.972549, 0.972549, 0.215686, 1.000000)
Tolerance (0.031250, 0.031250, 0.031250, 0.250000)
getteximage-formats failure: format: GL_SRGB_EXT, level 2 at pixel(421, 71)
 Expected (0.992157, 0.992157, 0.501961, 1.000000)
	 Found (0.956863, 0.956863, 0.215686, 1.000000)
Tolerance (0.031250, 0.031250, 0.031250, 0.250000)
getteximage-formats failure: format: GL_SRGB8_EXT, level 1 at pixel(369, 103)
 Expected (0.992157, 0.992157, 0.501961, 1.000000)
	 Found (0.972549, 0.972549, 0.215686, 1.000000)
Tolerance (0.031250, 0.031250, 0.031250, 0.250000)
getteximage-formats failure: format: GL_SRGB8_EXT, level 2 at pixel(421, 71)
 Expected (0.992157, 0.992157, 0.501961, 1.000000)
	 Found (0.956863, 0.956863, 0.215686, 1.000000)
Tolerance (0.031250, 0.031250, 0.031250, 0.250000)
getteximage-formats failure: format: GL_SRGB_ALPHA_EXT, level 1 at pixel(369, 103)
 Expected (0.690273, 0.690273, 0.449981, 0.240292)
	 Found (0.678431, 0.678431, 0.305882, 0.239216)
Tolerance (0.031250, 0.031250, 0.031250, 0.031250)
getteximage-formats failure: format: GL_SRGB_ALPHA_EXT, level 2 at pixel(421, 71)
 Expected (0.690273, 0.690273, 0.449981, 0.240292)
	 Found (0.670588, 0.670588, 0.305882, 0.239216)
Tolerance (0.031250, 0.031250, 0.031250, 0.031250)
getteximage-formats failure: format: GL_SRGB8_ALPHA8_EXT, level 1 at pixel(369, 103)
 Expected (0.690273, 0.690273, 0.449981, 0.240292)
	 Found (0.678431, 0.678431, 0.305882, 0.239216)
Tolerance (0.031250, 0.031250, 0.031250, 0.031250)
getteximage-formats failure: format: GL_SRGB8_ALPHA8_EXT, level 2 at pixel(421, 71)
 Expected (0.690273, 0.690273, 0.449981, 0.240292)
	 Found (0.670588, 0.670588, 0.305882, 0.239216)
Tolerance (0.031250, 0.031250, 0.031250, 0.031250)
PIGLIT: {"result": "fail" }


6cf8708ce55fb38c400c8f005e55170f54241187 is the first bad commit
commit 6cf8708ce55fb38c400c8f005e55170f54241187
Author: Kenneth Graunke <kenneth@whitecape.org>
Date:   Fri Aug 12 14:48:54 2016 -0700

    meta: Always do GenerateMipmaps in linear colorspace.
    
    When generating mipmaps for sRGB textures, force both decode and encode,
    so the filtering is done in linear colorspace, regardless of settings.
    
    Fixes a WebGL conformance test in Chrome:
    https://www.khronos.org/registry/webgl/sdk/tests/conformance2/textures/misc/tex-srgb-mipmap.html?webglVersion=2
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97322
    Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
    Reviewed-by: Topi Pohjolainen <topi.pohjolainen@intel.com>

:040000 040000 733e4c7b073125598497a608ebd397f141256506 55d86d5e6b408e71bb86f249941fd03d224934c7 M	src
bisect run success
Comment 1 Vinson Lee 2017-03-31 23:33:09 UTC
mesa: 150736b5c34fc07de296454b973ae72ede215ae2 (master 17.1.0-devel)

Regression is still present.
Comment 2 GitLab Migration User 2019-09-18 18:45:46 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/mesa/mesa/issues/324.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.