Bug 98327

*** Bug 98340 has been marked as a duplicate of this bug. ***

This test passes fine (with master or even old mesa) on my HSW, this could be something about sync between EGL and X.

This may be either X or window manager issue. When using Fedora I cannot trigger this failure at all while in Ubuntu it happens easily. Mark, what distro/wm are you using when testing?

I've gone through dEQP X11 EGL backend, it properly listens to ConfigureNotify events and listens to them, finally queries updated size using XGetGeometry.

I am reproducing these on the CI.  The CI is running debian testing.  It launches X directly from an ssh login, and there is no window manager running.

Created attachment 128539 [details] [review]
dEQP resize fix

This patch is required to make sure that we get the *exact* ConfigureNotify we are waiting for in dEQP.

Created attachment 128540 [details] [review]
RFC patch to Mesa to sync surface information

Mark, with these 2 patches the test is passing consistently now for me on Ubuntu. I made dEQP patch because I noticed that there's sometimes and 'unrelated' ConfigureNotify event in the queue with Ubuntu's WM, that one makes sure we get event with same size we asked for. Mesa patch if for making sure that we return up-to-date values. I'll send it as RFC to mesa-dev, it could be I'm misunderstanding something but for me it seems like nothing makes sure we have up-to-date values otherwise.

Created attachment 128541 [details] [review]
RFC patch to Mesa to sync surface information

oopsie, v2 with dri3 implementation also

Created attachment 128542 [details] [review]
dEQP resize fix

new version also for dEQP resize fix that contains only necessary changes

Created attachment 128543 [details] [review]
RFC patch to Mesa to sync surface information

more cleanups

Created attachment 128575 [details] [review]
Mesa fix to query surface geometry

and this is what I finally sent to mesa-dev ..

Tapani, I need the deqp fix to be rebased to nougat-cts-dev in order to test.

Created attachment 128592 [details] [review]
dEQP resize fix (rebase to nougat-cts-dev branch)

Mark, if dEQP fix seems 'hackish' there is also more elegant way of using XIfEvent() with a predicate rule to match an exact event to be waited, I can supply such alternative if wanted.

Mesa patch has been pushed upstream, waiting for comments to dEQP change.

Created attachment 128765 [details] [review]
dEQP resize fix (rebase to nougat-cts-dev branch) v2

This fix contains changes asked by Pyry. Will attempt to send this to AOSP gerrit.

uploaded dEQP fix to gerrit

nougat-cts-dev:
https://android-review.googlesource.com/#/c/320517/

master:
https://android-review.googlesource.com/#/c/321270/

will resolve this when/if this fix gets integrated.

fix landed to dEQP master branch

---8< ---
commit 0cfa22d49dc615b597d40421e92343fe7575681a
Author: Tapani Pälli <tapani.palli@intel.com>
Date:   Wed Jan 11 08:37:54 2017 +0200

    tcuX11: fix to wait for matching ConfigureNotify
    
    Patch adds a loop to setDimensions that spins until exact
    matching ConfigureNotify event is caught. This is done to make
    sure X has updated the window size before we get further.
    
    New processEvent method is added so that we can handle possible
    WM_DELETE_WINDOW message during the loop as suggested by Pyry.
    
    Test: run dEQP-EGL.functional.resize* on different configurations
    
    Change-Id: Ic32243e9b25ea6cbdb5a7ab6bfccc7a196f1a5b8
    Signed-off-by: Tapani Pälli <tapani.palli@intel.com>