| Summary: | [HSW] [regression] 4.9-rc1 shows corruption with mpv's vaapi-copy | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | DRI | Reporter: | Andreas Reis <andreas.reis> | ||||||||
| Component: | DRM/Intel | Assignee: | Andreas Reis <andreas.reis> | ||||||||
| Status: | CLOSED FIXED | QA Contact: | Intel GFX Bugs mailing list <intel-gfx-bugs> | ||||||||
| Severity: | blocker | ||||||||||
| Priority: | highest | CC: | cristi.magherusan, intel-gfx-bugs, Martin, ricardo.vega, seanvk | ||||||||
| Version: | DRI git | Keywords: | regression | ||||||||
| Hardware: | x86-64 (AMD64) | ||||||||||
| OS: | Linux (All) | ||||||||||
| Whiteboard: | |||||||||||
| i915 platform: | HSW | i915 features: | |||||||||
| Attachments: |
|
||||||||||
|
Description
Andreas Reis
2016-10-23 18:27:05 UTC
* places a bet that libva forgot once again to set the write hazard on their render targets. Other than timing issues, nothing immediately suggests itself. As you have two kernel endpoints, might as well begin the bisect there... So does vaapi-copy actually do a copy or are you deriving the surfaces to get the image? Sean Please test with yamidecode from libyami-utils. On Arch just yaourt libyami-utils. Sean I'm afraid you'll have to look at mpv's sources for what its vaapi-copy does precisely. libyami won't build for me on Arch, make DESTDIR="$pkgdir/" install instantly dies for me with Making install in common make[1]: Entering directory '/tmp/makepkg/libyami/src/libyami-libyami-1.0.0/common' make[2]: Entering directory '/tmp/makepkg/libyami/src/libyami-libyami-1.0.0/common' make[2]: Nothing to be done for 'install-exec-am'. /usr/bin/mkdir -p '/tmp/makepkg/libyami/pkg/libyami//usr/include/libyami' ../0 -m 644 YamiVersion.h '/tmp/makepkg/libyami/pkg/libyami//usr/include/libyami' /bin/sh: line 11: ../0: No such file or directory make[2]: *** [Makefile:679: install-libyami_commonincludeHEADERS] Error 127 Did you yaourt libyami first? Sean Odd yaourt libyami-utils installs fine for me, correctly pulling in libyami deps. I'm the package maintainer. I can help you with that later. Anyway, I will have a look at this issue on HSW. Tried again, suddenly it installs (used the git versions). Huh. yamidecode works fine, apart from all the texture render modes failing with "do not support this render mode". Okay, so I wonder if this is MPV specific then. Highest+Blocker due to regression w/o workaround This is not @jari a "highest blocker" It's not even a bug with the vaapi driver. From what I can tell the issue is specific to MPV. Sean There is still the issue that the observed behaviour changed between kernel versions. We really do need to identify why to rule out a kernel regression. Changed it back to highest blocker as it still needs to rule out a kernel issue... Humberto can you help me to reproduce this No longer need for a reproduction Humberto It's related to the partial fencing support. Other reports say it is fixed in -nightly, my suspicion is that https://cgit.freedesktop.org/drm-intel/commit/?h=drm-intel-next-queued&id=d2a84a76a3b970fa32e6eda3d85e7782f831379e is the likely fix, but I'm waiting upon confirmation. Created attachment 127809 [details] [review] Round min chunk size up to a tile row commit 0ef723cbceb6dce8116e75d44c5b8679b2eba69a Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Mon Nov 7 10:54:43 2016 +0000 drm/i915: Round tile chunks up for constructing partial VMAs When we split a large object up into chunks for GTT faulting (because we can't fit the whole object into the aperture) we have to align our cuts with the fence registers. Each partial VMA must cover a complete set of tile rows or the offset into each partial VMA is not aligned with the whole image. Currently we enforce a minimum size on each partial VMA, but this minimum size itself was not aligned to the tile row causing distortion. *** Bug 98504 has been marked as a duplicate of this bug. *** Andreas - Please see with the latest intel-drm-nightly if you can still reproduce the issue. Created attachment 127846 [details] gfx corruption with regular KDE/Qt application Konversation For now drm-intel-fixes branch (with all commits up to 54905ab5fe7aa453610e31cec640e528aaedb2e2) seems to work okay with the graphics glitches I saw as in (see attachment). As these look similar to the corruptions shown here and Jani pointed me to this bug report, I add the information here. I can only test with laptop display at the moment. But I will test with external display this evening – in case the issue at hand is DisplayPort related, but according to the git commit Chris mentioned in comment #17, it does not seem to be. For reference see: [REGRESSION] Linux 4.9-rc4: gfx glitches on Intel Sandybridge (was: Re: Linux 4.9-rc4) http://lkml.iu.edu/hypermail/linux/kernel/1611.0/02800.html As for me, vaapi-copy videos indeed play fine again. Also no graphics glitches with external DisplayPort connected display. *However*, I got a soft freeze and a hard freeze (well after about a minute I gave up and rebooted by pressing power button long enough to forcefully switch off the laptop) when playing PlaneShift using drm-intel-fixes branch. Unfortunately I have no further time to debug any of this week, but it seems not all fixes are there are ready for next stable kernel. v4.9-rc5 solved the gfx corruptions for me with regular KDE/Qt applications. Verified by Reporter. Closing Verified+Fixed. Martin, file another bug related to soft and hard freeze, if that is still a problem. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.