| Summary: | Support R8 image texture in ES 3.1 | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | Dongseong Hwang <dongseong.hwang> |
| Component: | Drivers/DRI/i965 | Assignee: | Lionel Landwerlin <lionel.g.landwerlin> |
| Status: | RESOLVED FIXED | QA Contact: | Intel 3D Bugs Mailing List <intel-3d-bugs> |
| Severity: | major | ||
| Priority: | high | CC: | lionel.g.landwerlin |
| Version: | 12.0 | ||
| Hardware: | x86-64 (AMD64) | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
|
Description
Dongseong Hwang
2016-10-28 18:34:51 UTC
According to the OpenGL ES Shading Language spec 3.10, section 4.4, the layout qualifier r8 doesn't seem to be supported. I'm afraid you'll have to bump the profile. Ah, I didn't know that. You are right. glBindImageTexture in ES 3.1 doesn't support R8 https://www.khronos.org/opengles/sdk/docs/man31/html/glBindImageTexture.xhtml glBindImageTexture in GL 4.2 support R8 tho https://www.opengl.org/sdk/docs/man4/html/glBindImageTexture.xhtml Will ES support R8 image texture in the future as extensions or upper version? It's not in the 3.20 spec. I don't know beyond that. There's a GL_NV_image_formats but it's not implemented by Mesa. Should be easy enough to add though. That's right. GL_NV_image_formats is sufficient to speed up ChromeOS. Could someone take a ownership this issue? FYI, I'm looking at adding the extension. Will post a link to the patches here. We should take some care with this. The set of required image formats selected for OpenGL ES 3.1 were picked specifically because they matched the set required by DX. This set should be natively supported by all hardware. This avoids the need for state-based recompiles. A number of the formats required by desktop OpenGL involve a significant amount of pain in shaders and state-based recompiles. I'd be reluctant to expose those formats on OpenGL ES unless there is clear and significant need for those formats. That said, R8 is not one of the painful formats. Aside from possibly R11F_G11F_B10F, I'm pretty sure none of the added formats are on the pain list either. Before committing to adding this specific extension, we should double check the list of added formats against the list of pain-free formats. ChromeOS uses GL ES 3.1 and needs R8 and RG8 support, because 1. Chromium has its own CMAA implementation and R8 support is critical. https://www.opengl.org/registry/specs/INTEL/framebuffer_CMAA.txt 2. Chromium uses R8 and RG8 to draw YUV video by itself. NV_image_formats supports too many formats, although it's GLES extension. If some formats cause lots of pain, I hope new extension which is subset of NV_image_formats, is added. https://www.khronos.org/registry/gles/extensions/NV/NV_image_formats.txt Hi Lionel-Any update here? Thanks. Just got some review feedback on the piglit tests : https://patchwork.freedesktop.org/series/15026/ Also have a couple of Mesa patches that don't seem to break our CI : https://github.com/djdeath/mesa/commits/NV_image_formats Mesa patches: https://patchwork.freedesktop.org/series/15174/ Piglit: https://patchwork.freedesktop.org/series/15173/ Lionel-Are you awaiting more feedback with these new patches? (In reply to Annie from comment #12) > Lionel-Are you awaiting more feedback with these new patches? I just got the reviewed-by for the Mesa patch, I'll land this today. Still waiting for the additional piglit one. Hi Lionel, Any update on this? Thanks! All done! Nice! Thank you! |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.