Bug 98573

Summary: Mesa build fail since radeonsi: use PS epilog for monolithic shaders
Product: Mesa Reporter: Andy Furniss <adf.lists>
Component: Drivers/Gallium/radeonsiAssignee: Default DRI bug account <dri-devel>
Status: RESOLVED FIXED QA Contact: Default DRI bug account <dri-devel>
Severity: normal    
Priority: medium CC: issor.oruam, nhaehnle
Version: git   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: Patch for android for the same issue

Description Andy Furniss 2016-11-03 14:05:35 UTC 
Making all in targets/pipe-loader
make[4]: Entering directory '/mnt/sdb1/Gits/mesa/src/gallium/targets/pipe-loader'
  CXXLD    pipe_radeonsi.la
../../../../src/gallium/drivers/radeonsi/.libs/libradeonsi.a(si_shader.o): In function `si_build_wrapper_function':
/mnt/sdb1/Gits/mesa/src/gallium/drivers/radeonsi/si_shader.c:6861: undefined reference to `ac_is_sgpr_param'
/mnt/sdb1/Gits/mesa/src/gallium/drivers/radeonsi/si_shader.c:6951: undefined reference to `ac_is_sgpr_param'
collect2: error: ld returned 1 exit status

commit 7115e56c21ace07cf04f5073ba73a533e2182099
Author: Nicolai Hähnle <nicolai.haehnle@amd.com>
Date:   Fri Oct 28 14:45:59 2016 +0200

    radeonsi: use PS epilog for monolithic shaders
Comment 1 Nicolai Hähnle 2016-11-03 14:29:46 UTC 
Yeah, this has been reported on IRC as well. I don't know why my build setup isn't affected by this. In any case, https://patchwork.freedesktop.org/patch/119816/ should fix it.
Comment 2 Andy Furniss 2016-11-03 14:46:10 UTC 
(In reply to Nicolai Hähnle from comment #1)
> Yeah, this has been reported on IRC as well. I don't know why my build setup
> isn't affected by this. In any case,
> https://patchwork.freedesktop.org/patch/119816/ should fix it.

Yea, Ok with that, thanks.
Comment 3 Nicolai Hähnle 2016-11-03 15:57:58 UTC 
Fixed in master.
Comment 4 Mauro Rossi 2016-11-04 23:17:32 UTC 
Created attachment 127775 [details] [review]
Patch for android for the same issue

Hi Nicolai,

please review the attached patch which is necessary fix android build.
Tested with nougat-x86 build
Kind regards

Mauro Rossi
issor.oruam@gmail.com
Comment 5 Marek Olšák 2016-11-05 17:43:46 UTC 
Mauro, I've just pushed your patch.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.