Bug 98764

Summary: [G33] 2,820 piglit assertions ralloc.c:84: get_header: Assertion `info->canary == 0x5A1106' failed.
Product: Mesa Reporter: Mark Janes <mark.a.janes>
Component: Drivers/DRI/i965Assignee: Timothy Arceri <t_arceri>
Status: CLOSED FIXED QA Contact: Intel 3D Bugs Mailing List <intel-3d-bugs>
Severity: blocker    
Priority: medium CC: kenneth
Version: git   
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:

Description Mark Janes 2016-11-17 19:56:25 UTC 
Bisected to:

0ad69e6b51b06c483db37c3b7eeb1da1a95d0629
Author:     Timothy Arceri <timothy.arceri@collabora.com>

mesa: make use of ralloc when creating ARB asm gl_program fields

This will allow us to move the ARB asm fields in gl_program into
a union as we will be able call ralloc_free() on the entire struct
when destroying the context.

In this change we switch over to using ralloc for the Instructions,
String and LocalParams fields of gl_program.

Reviewed-by: Emil Velikov <emil.velikov@collabora.com>


In addition to the many assertions in piglit, the GLES CTS dies completely on G33.  Other platforms are unaffected.
Comment 1 Timothy Arceri 2016-11-18 00:54:46 UTC 
This fixes swrast bug 98767 I suspect it shoudl fix G33 too:

https://patchwork.freedesktop.org/patch/122114/
Comment 2 Timothy Arceri 2016-11-18 12:43:07 UTC 
I've pushed a change that should fix this:

commit 88fe2c308ec0902b8f3980f9ce6ab6241ba74c14
Author: Timothy Arceri <timothy.arceri@collabora.com>
Date:   Fri Nov 18 11:51:59 2016 +1100

    mesa: fix old classic drivers to use ralloc for ARB asm programs
    
    These changes were missed in 0ad69e6b5.
    
    Acked-by: Edward O'Callaghan <funfunctor@folklore1984.net>
    Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98767

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.