Bug 98854

Summary:	segfault with javafx fullscreen + yakuake when compositing disabled
Product:	xorg	Reporter:	Christoph Haag <haagch>
Component:	Server/General	Assignee:	Xorg Project Team <xorg-team>
Status:	RESOLVED FIXED	QA Contact:	Xorg Project Team <xorg-team>
Severity:	normal
Priority:	medium
Version:	git
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Christoph Haag 2016-11-25 13:14:17 UTC

Found this while testing this program https://gist.github.com/ChristophHaag/661be992429b451218e9ee1fb0eacdec
Happens on X.org 1.18 and 1.19.

Steps to reproduce:
Disable compositing
start java Jfxtest
quickly press the hotkey for opening yakuake, possibly several times
X.org will likely crash.

With debug symbols I caught this assert:

#0  0x00007ffff5cc804f in raise () at /usr/lib/libc.so.6
#1  0x00007ffff5cc947a in abort () at /usr/lib/libc.so.6
#2  0x00007ffff5cc0ea7 in __assert_fail_base () at /usr/lib/libc.so.6
#3  0x00007ffff5cc0f52 in  () at /usr/lib/libc.so.6
#4  0x000055555568a9cb in  ()
#5  0x00007ffff158d0da in amdgpu_present_vblank_handler (crtc=0x555555afa180, msc=921668, usec=15442866662, data=0x555556c130f0) at amdgpu_present.c:132
        event = 0x555556c130f0
#6  0x00007ffff1587194 in amdgpu_drm_queue_handler (fd=13, frame=921668, sec=15442, usec=866662, user_ptr=0x5d) at amdgpu_drm_queue.c:70
        seq = 93
        e = 0x5555569ed520
        tmp = 0x555556a3bec0
#7  0x00007ffff704d5c6 in drmHandleEvent () at /usr/lib/libdrm.so.2
#8  0x00007ffff15935f6 in drmmode_notify_fd (fd=13, notify=1, data=0x5555559f9e78) at drmmode_display.c:2120
        drmmode = 0x5555559f9e78
#9  0x000055555570cf89 in  ()
#10 0x0000555555705c6d in WaitForSomething ()
#11 0x00005555555a56ca in  ()
#12 0x00005555555a9a48 in  ()
#13 0x00007ffff5cb5291 in __libc_start_main () at /usr/lib/libc.so.6

Comment 1 Michel Dänzer 2016-11-28 01:56:34 UTC

https://patchwork.freedesktop.org/patch/124201/ fixes this.

Comment 2 Christoph Haag 2016-11-28 07:27:13 UTC

It does indeed fix it, thanks.

Comment 3 Christoph Haag 2016-12-25 00:10:55 UTC

This patch still needs to be committed, right?

Comment 4 Michel Dänzer 2017-01-10 03:46:04 UTC

Thanks for the report and testing, fixed in Git:

commit e473b2bc016adacfe3fa47fdf6a8ce9f8cddff62
Author: Michel Dänzer <michel.daenzer@amd.com>
Date:   Fri Nov 25 17:34:05 2016 +0900

    present: Only call present_flip_notify if vblank->queued == FALSE

Comment 5 Julien Isorce 2017-05-23 10:32:04 UTC

Hi, could you apply this patch to branch 1.18 too ? It applies cleanly and will help Ubuntu 16.04 . Thx!

Comment 6 Michel Dänzer 2017-05-24 01:38:21 UTC

I don't think the upstream 1.18 branch is active anymore, so you should probably ask the Ubuntu package maintainers to backport the fix instead.

Comment 7 Julien Isorce 2017-05-25 10:32:54 UTC

Done here https://bugs.launchpad.net/ubuntu/+source/xorg-server/+bug/1693379

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.