Bug 98921

Summary:	[patch] pdftops from 01dec2016 git gets Syntax Error (895): Arg #0 to 'Tj' operator is wrong type (hexstring)
Product:	poppler	Reporter:	William Bader <williambader>
Component:	utils	Assignee:	poppler-bugs <poppler-bugs>
Status:	RESOLVED INVALID	QA Contact:
Severity:	normal
Priority:	medium	CC:	jakubalba, williambader
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	patch to fix the problem

Description William Bader 2016-12-01 06:15:26 UTC

Created attachment 128295 [details]
patch to fix the problem

Recent changes to fix problems with hexstrings cause hexstrings to come in places where poppler expects a string. The test PDF in https://bugs.freedesktop.org/show_bug.cgi?id=63963 shows the problem, but many other PDFs show the problem as well.
The attached patch seem to fix the problem for me.

Comment 1 Albert Astals Cid 2016-12-01 21:35:57 UTC

Jakub, your patch broke everything (blame is on me for not really testing it through).

I'm unsure of whether i should commit William's patch or just revert your patch altogether. 

Please try to convince me that your patch is worth the trouble.

Comment 2 Jakub Alba 2016-12-01 21:46:35 UTC

(In reply to Albert Astals Cid from comment #1)
> Please try to convince me that your patch is worth the trouble.

TBH I don't think it is worth the trouble if there is going to be more of such trouble. And predicting it would be hard. So I'd be in favor of reverting. Sorry.

Comment 3 Albert Astals Cid 2016-12-01 23:10:54 UTC

Ok, i have reverted the hexstring patches, please try to see if you can implement what they did in a less intrusive way maybe.

I'll close this bug since the patch no longer applies.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.