Bug 990

Summary: Compiling with Composite causes incorrect colors on radeon driver
Product: xorg Reporter: Kevin E. Martin <kem>
Component: Server/GeneralAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: high CC: eta, keithp, stuart.kreitman
Version: git   
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 351    

Description Kevin E. Martin 2004-08-05 16:09:53 UTC 
It seems that when you compile the server with Composite, the color tables are
sometimes incorrectly initialized.  Go through several server generations and
you should easily see this problem.

I have tracked this down to the changes in dix/colormap.c.  When I compile with
-UCOMPOSITE on that file alone, the problems go away.  I suspect this has to do
with alphaMask (and offsetAlpha) not being initialized.  I see that there are
some cases where they are initialized in the composite/compinit.c but that code
only affects the alternate visuals.

Where should alphaMask/offsetAlpha initialized for the standard visuals?  And
what should they be initialized to?

I suspect this will cause problems on other drivers as well.
Comment 1 Eric Anholt 2004-08-05 21:55:45 UTC 
There's one hunk of diff missing for fb/fbcmap.c for COMPOSITE, but that wasn't
enough.  I'll take a look at this when I get back (monday) if nobody beats me.
Comment 2 Keith Packard 2004-08-06 19:35:04 UTC 
I've eliminated the core colormap changes for Composite.  That should fix this bug.
Comment 3 Kevin E. Martin 2004-08-09 12:20:45 UTC 
Yes, that fixed the problem.
Closing.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.