Bug 99170

Summary: cancelled file transfer causes critical messages
Product: Spice Reporter: Pavel Grunt <pavelgrunt>
Component: spice-gtkAssignee: Spice Bug List <spice-bugs>
Status: RESOLVED WORKSFORME QA Contact:
Severity: normal    
Priority: medium CC: bugzilla, pavelgrunt
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: bt for Comment 2

Description Pavel Grunt 2016-12-21 15:36:56 UTC 
When the file transfer is cancelled or when it has an error on the guest/host side, client logs a few criticals:

(spicy:6544): GSpice-DEBUG: spice-file-transfer-task.c:303 File mycd.iso xfer failed: The spice agent reported an error during the file transfer
(spicy:6544): GSpice-WARNING **: The spice agent reported an error during the file transfer
(spicy:6544): GSpice-DEBUG: channel-main.c:1853 xfer-task 1 received response 2
(spicy:6544): GSpice-CRITICAL **: spice_main_channel_find_xfer_task_by_task_id: assertion 'xfer_op != NULL' failed
(spicy:6544): GSpice-CRITICAL **: main_agent_handle_xfer_status: assertion 'xfer_task != NULL' failed
Comment 2 Pavel Grunt 2017-02-07 17:46:34 UTC 
I am unable to reproduce now. I get some glib warnings, but nothing similar to the original bug :/:

(spicy:24089): GSpice-DEBUG: spice-file-transfer-task.c:303 File /home/pgrunt/Videos/bigfile2 xfer failed: Agent connection closed

** (spicy:24089): WARNING **: Agent connection closed

(spicy:24089): GLib-CRITICAL **: g_hash_table_iter_next: assertion 'ri->version == ri->hash_table->version' failed


the reproducer:
1. initiate the transfer (big file so the transfer dialog stays for a moment)
2. restart the guest (kill the agent)

glib2-2.51.0-2.fc26.x86_64

bt:
#0  0x00007ffff15b5b01 in _g_log_abort (breakpoint=breakpoint@entry=1) at gmessages.c:487
#1  0x00007ffff15b6f0d in g_logv (log_domain=0x7ffff15f880e "GLib", log_level=G_LOG_LEVEL_CRITICAL, format=<optimized out>, args=args@entry=0x7fffdffff8f0) at gmessages.c:1296
#2  0x00007ffff15b706f in g_log (log_domain=log_domain@entry=0x7ffff15f880e "GLib", log_level=log_level@entry=G_LOG_LEVEL_CRITICAL, format=format@entry=0x7ffff1602025 "%s: assertion '%s' failed") at gmessages.c:1337
#3  0x00007ffff15b74e9 in g_return_if_fail_warning (log_domain=log_domain@entry=0x7ffff15f880e "GLib", pretty_function=pretty_function@entry=0x7ffff15fd650 <__func__.10325> "g_hash_table_iter_next", expression=expression@entry=0x7ffff15fd2c8 "ri->version == ri->hash_table->version") at gmessages.c:2456
#4  0x00007ffff159e930 in g_hash_table_iter_next (iter=iter@entry=0x7fffdffffa00, key=key@entry=0x7fffdffff9f0, value=value@entry=0x7fffdffff9f8) at ghash.c:791
#5  0x00007ffff78a301e in spice_main_channel_reset_all_xfer_operations (channel=0x55555580a1a0 [SpiceMainChannel]) at channel-main.c:2923
#6  0x00007ffff78a301e in spice_main_channel_reset_agent (channel=0x55555580a1a0 [SpiceMainChannel]) at channel-main.c:418
#7  0x00007ffff78a301e in set_agent_connected (channel=0x55555580a1a0 [SpiceMainChannel], connected=<optimized out>) at channel-main.c:1543
#8  0x00007ffff7892e1c in spice_channel_recv_msg (channel=0x55555580a1a0 [SpiceMainChannel], msg_handler=<optimized out>, data=0x0) at spice-channel.c:2024
#9  0x00007ffff7893064 in spice_channel_iterate_read (channel=0x55555580a1a0 [SpiceMainChannel]) at spice-channel.c:2262
#10 0x00007ffff7894d65 in spice_channel_iterate (channel=0x55555580a1a0 [SpiceMainChannel]) at spice-channel.c:2300
#11 0x00007ffff7894d65 in spice_channel_coroutine (data=0x55555580a1a0) at spice-channel.c:2587
#12 0x00007ffff78c518b in coroutine_trampoline (cc=0x555555809830) at coroutine_ucontext.c:63
#13 0x00007ffff78c4fb3 in continuation_trampoline (i0=<optimized out>, i1=<optimized out>) at continuation.c:55
#14 0x00007ffff0fc65e0 in __start_context () at /lib64/libc.so.6
#15 0x0000555555809bf8 in  ()
#16 0x0000000000000000 in  ()
Comment 3 Pavel Grunt 2017-02-07 17:47:17 UTC 
Created attachment 129397 [details]
bt for Comment 2
Comment 4 Pavel Grunt 2017-02-08 13:51:19 UTC 
closing

I am unable to reproduce the original issue and the problem mentioned in the comment 2 is fixed by https://cgit.freedesktop.org/spice/spice-gtk/commit/?id=01bb9bb30517b0ea3bdb230d40b2835c53a9cf59

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.