Bug 99244

Summary:	hud_context.c:874:45: error: ‘W_OK’ undeclared
Product:	Mesa	Reporter:	Vinson Lee <vlee>
Component:	Mesa core	Assignee:	mesa-dev
Status:	RESOLVED FIXED	QA Contact:	mesa-dev
Severity:	normal
Priority:	medium	CC:	edmondo.tommasina, maraeo
Version:	git	Keywords:	bisected, regression
Hardware:	x86-64 (AMD64)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:

Description Vinson Lee 2017-01-02 01:30:29 UTC

mesa: 3f5fba8a7be61bfc0f46a5ea058108f6e0e1c268 (master 13.1.0-devel)

  Compiling src/gallium/auxiliary/hud/hud_context.c ...
src/gallium/auxiliary/hud/hud_context.c: In function ‘hud_graph_set_dump_file’:
src/gallium/auxiliary/hud/hud_context.c:874:24: warning: implicit declaration of function ‘access’ [-Wimplicit-function-declaration]
    if (hud_dump_dir && access(hud_dump_dir, W_OK) == 0) {
                        ^~~~~~
src/gallium/auxiliary/hud/hud_context.c:874:45: error: ‘W_OK’ undeclared (first use in this function)
    if (hud_dump_dir && access(hud_dump_dir, W_OK) == 0) {
                                             ^~~~

22cd9040da75cac6e1c61b821e1ac6906ac4a8ac is the first bad commit
commit 22cd9040da75cac6e1c61b821e1ac6906ac4a8ac
Author: Edmondo Tommasina <edmondo.tommasina@gmail.com>
Date:   Wed Dec 21 22:58:09 2016 +0100

    gallium/hud: dump hud_driver_query values to files
    
    Dump values for every selected data source in GALLIUM_HUD.
    
    Every data source has its own file and the filename is
    equal to the data source identifier.
    
    Set GALLIUM_HUD_DUMP_DIR to dump values to files in this directory.
    
    No values are dumped if the environment variable is not set, the
    directory doesn't exist or the user doesn't have write access.
    
    Signed-off-by: Marek Olšák <marek.olsak@amd.com>

:040000 040000 c269ea1aa72e829368e14dc3f923521c2d2de355 e297a9c27c8397302ab9ba61578eacab98cb8bc3 M	src
bisect run success

Comment 1 Vinson Lee 2017-01-04 00:00:52 UTC

commit cb6f49a902cae1b4df795c0e611526dca467a042
Author: Marek Olšák <marek.olsak@amd.com>
Date:   Mon Jan 2 23:16:48 2017 +0100

    gallium/hud: fix the windows build by disabling file dumping

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.