Bug 99309

Summary: [radeonsi]glsl: Override the # of varying slots for ClipDistance and TessLevel*. broke chromium browser
Product: Mesa Reporter: Arek Ruśniak <arek.rusi>
Component: Drivers/Gallium/radeonsiAssignee: Default DRI bug account <dri-devel>
Status: RESOLVED FIXED QA Contact: Default DRI bug account <dri-devel>
Severity: normal    
Priority: medium    
Version: git   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: chomium look

Description Arek Ruśniak 2017-01-07 14:47:06 UTC 
Hi, after upgrade mesa-git chromium starts looking like garbage.
I've tested this on polaris and i965(haswell) and only radeon is infected
kernel - 4.9 or 4.10-drm-next-wip
mesa - from git
llvm - r291295
ddx - amdgpu-git

bisecting:

8b5749f65ac434961308ccb579fb8a816e4f29d5 is the first bad commit
commit 8b5749f65ac434961308ccb579fb8a816e4f29d5
Author: Kenneth Graunke <kenneth@whitecape.org>
Date:   Sun Nov 15 04:37:50 2015 -0800

    glsl: Override the # of varying slots for ClipDistance and TessLevel*.
    
    Right now, this shouldn't have any effect, as all drivers use
    LowerClipDist and LowerTessFactors to turn the float[] arrays into
    vectors.
    
    However, it should help make it possible for drivers to avoid that
    lowering.
    me is the only issue for now
    Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
    Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
    Reviewed-by: Timothy Arceri <timothy.arceri@collabora.com>

after reverting, browser works corectly
Comment 1 Arek Ruśniak 2017-01-07 15:17:49 UTC 
Created attachment 128805 [details]
chomium look
Comment 2 Edmondo Tommasina 2017-01-07 21:09:33 UTC 
Same here. After updating to mesa-git Chromium with gpu acceleration shows only garbage.

OpenGL renderer string: Gallium 0.4 on AMD POLARIS10 (DRM 3.8.0 / 4.9.0-gentoo, LLVM 3.9.0)
Comment 3 Arek Ruśniak 2017-01-07 23:40:08 UTC 
ok, after commit "Revert recent GLSL slot counting fiasco" this raport should disappear

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.