Bug 99407

Summary:	Less / Greater key not working with german keyboard layout
Product:	Spice	Reporter:	Christian <chgauert>
Component:	spice-gtk	Assignee:	Pavel Grunt <pavelgrunt>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	pavelgrunt
Version:	unspecified
Hardware:	x86-64 (AMD64)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	Support '<>' key in Xfree86 and X11 Add more keys for Xfree86 and X11 Add more keys for Xfree86 and X11

Description Christian 2017-01-14 12:45:35 UTC

The less/greater/pipe key (left to Y) is not working when connected to a Windows VM using spice protocol.
With VNC or RDP connected to same VM the key works without problem
Afte looking thrue the code i found that the files 
src/vncdisplaykeymap_x112xtkbd.c and src/vncdisplaykeymap_xorgkbd2xtkbd.c do not contain a key mapping for that key - and on my system vncdisplaykeymap_xorgkbd2xtkbd is used to map keys according to debug output.
Adding [0x5e] = 0x56,       /* 94 => 86 via 86  to both files fixed the problem for me but the key should be added to the keymap.csv file somehow

Comment 1 Pavel Grunt 2017-01-15 17:39:29 UTC

Created attachment 128971 [details] [review]
Support '<>' key in Xfree86 and X11

Hi, thanks for the investigation!
Can you check if the attached patch works ?

Comment 2 Christian 2017-01-15 22:10:18 UTC

Hi
i found also key F11 and F12 not working - i guess they are missing too
could you add them too?
i'll check it later this week
Thanks

Comment 3 Pavel Grunt 2017-01-15 23:10:34 UTC

Created attachment 128974 [details] [review]
Add more keys for Xfree86 and X11

Comment 4 Pavel Grunt 2017-01-19 17:10:41 UTC

Created attachment 129050 [details] [review]
Add more keys for Xfree86 and X11

Posted at https://lists.freedesktop.org/archives/spice-devel/2017-January/034999.html

Comment 5 Pavel Grunt 2017-02-01 20:31:54 UTC

Fixed in 710b7377a212744254c39e4060deab43cf3f365a

Comment 6 Christian 2017-02-02 20:45:58 UTC

less/greater/pipe key, function key F11 and F12 are working now

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.