Bug 99422

Summary: Cannot clone cairo: Invalid tag
Product: cairo Reporter: Jan Alexander Steffens (heftig) <jan.steffens>
Component: generalAssignee: Chris Wilson <chris>
Status: RESOLVED MOVED QA Contact: cairo-bugs mailing list <cairo-bugs>
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:

Description Jan Alexander Steffens (heftig) 2017-01-15 17:57:46 UTC
~> git --version
git version 2.11.0

~> git clone git://anongit.freedesktop.org/cairo
Cloning into 'cairo'...
remote: Counting objects: 70386, done.
remote: Compressing objects: 100% (25665/25665), done.
error: object e5b831b107ad18e78ec9ea5e6da68eb30bf71126: missingSpaceBeforeDate: invalid author/committer line - missing space before date
fatal: Error in object
fatal: index-pack failed

The object is https://cgit.freedesktop.org/cairo/tag/?id=RELEASE_0_9_2
Comment 1 Jan Alexander Steffens (heftig) 2017-02-14 09:09:28 UTC
Turns out this was because the configuration included transfer.fsckObjects=true. Without that option, git does not check the received objects.

git fsck reports:

error in tag e5b831b107ad18e78ec9ea5e6da68eb30bf71126: missingSpaceBeforeDate: invalid author/committer line - missing space before date
error in tag 88955494ad8f94a103c79a1f1bbab92fd8f3df65: missingSpaceBeforeDate: invalid author/committer line - missing space before date
error in tag 5af154997df3d681013019273c7c9ecdb12e1f69: missingSpaceBeforeDate: invalid author/committer line - missing space before date
error in tag f4203442e5c2ce8126de95982300989e8108fa16: missingSpaceBeforeDate: invalid author/committer line - missing space before date
error in tag e34dde73595136d47ca904ffe8a3ade61fdd0b26: missingSpaceBeforeDate: invalid author/committer line - missing space before date
error in tag 29e5b9c44e8776092998d222002212e5e15777e9: missingSpaceBeforeDate: invalid author/committer line - missing space before date
error in tag f2e47d0ecf97d82983e0e5d1a3ee6e7cc7096694: missingSpaceBeforeDate: invalid author/committer line - missing space before date
error in tag 462062f4f5256fff9a820675731a39950295b116: missingSpaceBeforeDate: invalid author/committer line - missing space before date
error in tag 0e1f8ca5fc828e57148b17f949ad802b162544d9: missingSpaceBeforeDate: invalid author/committer line - missing space before date

Corresponding to the tags:

RELEASE_0_9_2
RELEASE_1_0_0
RELEASE_1_0_2
SNAPSHOT_0_1_1
SNAPSHOT_0_1_2
SNAPSHOT_0_1_3
SNAPSHOT_0_1_4
SNAPSHOT_0_1_5
SNAPSHOT_0_1_6

Still, I think the repository should not include bad tags. Maybe they can be recreated with something like this:

fixup() {
  GIT_COMMITTER_DATE="$(git log -1 --pretty=%cI $1)" \
  git -c user.name='Carl Worth' -c user.email='cworth@cworth.org' \
      tag -f -m '' $1 $1'^{commit}'
}
Comment 2 Daniel Stone 2017-02-14 09:34:41 UTC
The tags could be recreated, but that tends to make people uneasy.
Comment 3 Jan Alexander Steffens (heftig) 2017-02-14 09:39:06 UTC
They're historical and not signed, either.

The more important tags such as 1.0.0 (which tags the same commit as RELEASE_1_0_0 but is signed) and later would not be touched.
Comment 4 GitLab Migration User 2018-08-25 13:41:51 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/cairo/cairo/issues/145.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.