Bug 99534

Summary: tap to click regressed in 1.6.0
Product: Wayland Reporter: Ritesh Raj Sarraf <rrs>
Component: libinputAssignee: Wayland bug list <wayland-bugs>
Status: RESOLVED DUPLICATE QA Contact:
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: Linux (All)   
See Also: https://bugs.freedesktop.org/show_bug.cgi?id=99447
Whiteboard:
i915 platform: i915 features:
Attachments: evemu libinput 1.6.0

Description Ritesh Raj Sarraf 2017-01-25 13:52:30 UTC
Created attachment 129139 [details]
evemu libinput 1.6.0

Hello Peter,

Debian just pushed 1.6.0 version of libinput. Since the upgrade, I notice that tap to click is not working proper.

Most of the times, single taps are not registered as a single click. I've attached evemu-record output with single tap.
Comment 1 hakaa 2017-01-25 21:00:30 UTC
After diagnosing the problem and preparing a bug report, I realised that similar bugs were already submitted (99447, 99534).
However, I'll go ahead and paste/attach my finding, as it might help the developer further, here is my was-to-be bug report:

[Description]

Simply, when I "tap-to-click" fast enough, everything works as expected,
however, when I tap slowly, it won't register as a click.

See below, it seems as if libinput thinks it is a "click-and-hold".

Note, the slow tap is really not that slow, say sub 200ms, also, the exact
behaviour works under version 1.5.4

Attached is a recordings using evemu to reproduce the behaviour.

[Command I ran]

sudo libinput-debug-events --enable-tap --verbose

[Simplified events]

[[When the tap is missed]]

tap state: TAP_STATE_IDLE → TAP_EVENT_TOUCH → TAP_STATE_TOUCH
tap state: TAP_STATE_TOUCH → TAP_EVENT_TIMEOUT → TAP_STATE_HOLD
tap state: TAP_STATE_HOLD → TAP_EVENT_RELEASE → TAP_STATE_IDLE

[[When the tap is registered]]

tap state: TAP_STATE_IDLE → TAP_EVENT_TOUCH → TAP_STATE_TOUCH
tap state: TAP_STATE_TOUCH → TAP_EVENT_RELEASE → TAP_STATE_TAPPED
 event15  POINTER_BUTTON   +66.16s	BTN_LEFT (272) pressed, seat count: 1
tap state: TAP_STATE_TAPPED → TAP_EVENT_TIMEOUT → TAP_STATE_IDLE
 event15  POINTER_BUTTON   +66.39s	BTN_LEFT (272) released, seat count: 0
Comment 2 hakaa 2017-01-25 21:00:52 UTC

*** This bug has been marked as a duplicate of bug 99447 ***
Comment 3 hakaa 2017-01-25 21:01:54 UTC
Hi Ritesh Raj Sarraf,

I've marked this as duplicate, please follow 99447.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.