| Summary: | Let dbus-daemon return allowed auth mechanisms in case of rejected auth. | ||
|---|---|---|---|
| Product: | dbus | Reporter: | Ralf Habacker <ralf.habacker> |
| Component: | core | Assignee: | D-Bus Maintainers <dbus> |
| Status: | RESOLVED FIXED | QA Contact: | D-Bus Maintainers <dbus> |
| Severity: | normal | ||
| Priority: | medium | CC: | ralf.habacker |
| Version: | unspecified | Keywords: | patch |
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | review+ | ||
| i915 platform: | i915 features: | ||
| Bug Depends on: | |||
| Bug Blocks: | 99512 | ||
| Attachments: |
Let dbus-daemon return allowed auth mechanisms in case of rejected auth.
Do not mention disallowed auth mechanisms in REJECTED message |
||
|
Description
Ralf Habacker
2017-01-31 21:12:45 UTC
Created attachment 129262 [details] [review] Let dbus-daemon return allowed auth mechanisms in case of rejected auth. Moved from https://bugs.freedesktop.org/show_bug.cgi?id=96577#c59. Changes from partial review there has been fixed. Comment on attachment 129262 [details] [review] Let dbus-daemon return allowed auth mechanisms in case of rejected auth. Review of attachment 129262 [details] [review]: ----------------------------------------------------------------- The code looks good, but coming back to this without context I found the commit message confusing. It says > Let dbus-daemon return allowed auth mechanisms in case of rejected auth but that isn't really the important/interesting part of the change - the dbus-daemon already returns a list of mechanisms. What is important here is that previously it returned all *implemented* mechanisms, whereas now you are only returning the *allowed* ones. So I think it would be clearer with a commit message more like: > Do not mention disallowed auth mechanisms in REJECTED message > > Previously, all implemented mechanisms were included, even if the > sysadmin had configured them not to be allowed. The leftover reference to Bug #96577 is also a bit confusing and should probably be removed. I think this looks good to land with a clearer commit message though. Created attachment 129280 [details] [review] Do not mention disallowed auth mechanisms in REJECTED message - commit message fix committed to git master (This will be in 1.11.10) |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.