Bug 99692

Created attachment 129360 [details]
vulkaninfo output

Created attachment 129361 [details]
xdpyinfo output

I can confirm that this visual corruption is present on my R9 290 when radeon is blacklisted on the current Arch kernel. It affects the desktop with and without the compositor, and causes vulkan games to crash.

The Radeon R9 290X (Hawaii XT) is affected by this as well (on today's mesa master).

I haven't tried it in months as I've been using teh amdgpu-pro stack due to the same rendering issues on my R9 390, I did inform dave and baz about it then.

Can confirm the same with a 290 on Linux 4.9.8 using mesa-git, amdgpu-git.

Sascha Willems' triangle demo flickers and clicking 'maximise' on the window results in this error in console:

Fatal : VkResult is "ERROR_OUT_OF_DATE_KHR" in /opt/Vulkan/triangle/triangle.cpp at line 333
triangle: /opt/Vulkan/triangle/triangle.cpp:333: void VulkanExample::draw(): Assertion `res == VK_SUCCESS' failed.
Aborted (core dumped)

I've posted some patches to the mesa development list that should hopefully fix the VM faults. Please test them.

https://patchwork.freedesktop.org/series/19593/

is the series.

(In reply to Dave Airlie from comment #8)
> https://patchwork.freedesktop.org/series/19593/
> 
> is the series.

I can confirm, that all the issues I was seeing as reported in comment #0 are resolved by applying that series. You can have my:
  Tested-by: Kai Wasserbäch <kai@dev.carbon-project.org>

The full stack I used was(Debian testing as a base) is:
GPU: Hawaii PRO [Radeon R9 290] (ChipID = 0x67b1)
Mesa: Git:master/956556b3c3 + attachment 127922 [details] [review] (bug 97988), <https://patchwork.freedesktop.org/patch/138473/> (see bug 99542) and <https://patchwork.freedesktop.org/series/19593/>
libdrm: Git:master/d4b8344363 (tag libdrm-2.4.75)
LLVM: SVN:trunk/r294982 (5.0 devel) + <https://reviews.llvm.org/D26348?download=true> (bug 97988)
X.Org: 2:1.19.1-4
Linux: 4.9.9
Firmware (firmware-amd-graphics): 20160824-1
libclc: Git:master/2ec7d80d5e
DDX (xserver-xorg-video-amdgpu): 1.2.0-1+b1

Created attachment 129602 [details]
dota2 gdb backgrace

(In reply to Kai from comment #9)
> The full stack I used was(Debian testing as a base) is:
> GPU: Hawaii PRO [Radeon R9 290] (ChipID = 0x67b1)
> Mesa: Git:master/956556b3c3 + attachment 127922 [details] [review] [review] (bug
> 97988), <https://patchwork.freedesktop.org/patch/138473/> (see bug 99542)
> and <https://patchwork.freedesktop.org/series/19593/>
> libdrm: Git:master/d4b8344363 (tag libdrm-2.4.75)
> LLVM: SVN:trunk/r294982 (5.0 devel) +
> <https://reviews.llvm.org/D26348?download=true> (bug 97988)

Is LLVM-5.0-devel required? I am using LLVM-4.0.0_rc1 and even vulkaninfo is terminating with an assertion error.

(In reply to Jan Ziak from comment #11)
> (In reply to Kai from comment #9)
> > The full stack I used was(Debian testing as a base) is:
> > GPU: Hawaii PRO [Radeon R9 290] (ChipID = 0x67b1)
> > Mesa: Git:master/956556b3c3 + attachment 127922 [details] [review] [review] [review] (bug
> > 97988), <https://patchwork.freedesktop.org/patch/138473/> (see bug 99542)
> > and <https://patchwork.freedesktop.org/series/19593/>
> > libdrm: Git:master/d4b8344363 (tag libdrm-2.4.75)
> > LLVM: SVN:trunk/r294982 (5.0 devel) +
> > <https://reviews.llvm.org/D26348?download=true> (bug 97988)
> 
> Is LLVM-5.0-devel required? I am using LLVM-4.0.0_rc1 and even vulkaninfo is
> terminating with an assertion error.

Not to my knowledge and not intentionally I would venture to say, otherwise proposed changes including different behaviour depending on whether you have LLVM < 4.0.0 or not wouldn't make too much sense. Or it could just be a broken assertion somewhere? My non-asserting build here works now.

In any case your issue looks like a different problem from what this bug was/is about (graphical corruption and VM faults with radv and CIK ASICS), please file a separate report for it.

fixes pushed, thanks for testing.

(In reply to Jan Ziak from comment #11)
> (In reply to Kai from comment #9)
> > The full stack I used was(Debian testing as a base) is:
> > GPU: Hawaii PRO [Radeon R9 290] (ChipID = 0x67b1)
> > Mesa: Git:master/956556b3c3 + attachment 127922 [details] [review] [review] [review] (bug
> > 97988), <https://patchwork.freedesktop.org/patch/138473/> (see bug 99542)
> > and <https://patchwork.freedesktop.org/series/19593/>
> > libdrm: Git:master/d4b8344363 (tag libdrm-2.4.75)
> > LLVM: SVN:trunk/r294982 (5.0 devel) +
> > <https://reviews.llvm.org/D26348?download=true> (bug 97988)
> 
> Is LLVM-5.0-devel required? I am using LLVM-4.0.0_rc1 and even vulkaninfo is
> terminating with an assertion error.

If we detect 4.0, we use a patch that got backported to the 4.0 branch after rc1, so you might need to use rc2+ or a svn version.

(In reply to Kai from comment #12)
> (In reply to Jan Ziak from comment #11)
> > Is LLVM-5.0-devel required? I am using LLVM-4.0.0_rc1 and even vulkaninfo is
> > terminating with an assertion error.
> 
> Not to my knowledge and not intentionally I would venture to say, otherwise
> proposed changes including different behaviour depending on whether you have
> LLVM < 4.0.0 or not wouldn't make too much sense. Or it could just be a
> broken assertion somewhere? My non-asserting build here works now.

llvm-git works without issues.

> In any case your issue looks like a different problem from what this bug
> was/is about (graphical corruption and VM faults with radv and CIK ASICS),
> please file a separate report for it.

It is true that it was a problem different from this bug.

----

Back to this bug:

Dota2 -vulkan (observer mode) is working without issues on my R9-390.