Bug 99901

Summary: doc: Clarify /etc/dbus-1/system.d and /usr/share/dbus-1/system.d
Product: dbus Reporter: Philip Withnall <bugzilla>
Component: coreAssignee: D-Bus Maintainers <dbus>
Status: RESOLVED FIXED QA Contact: D-Bus Maintainers <dbus>
Severity: normal    
Priority: medium CC: bugzilla
Version: unspecifiedKeywords: patch
Hardware: All   
OS: All   
Whiteboard: review+
i915 platform: i915 features:
Attachments: doc: Clarify /etc/dbus-1/system.d and /usr/share/dbus-1/system.d
doc: Clarify /etc/dbus-1/system.d and /usr/share/dbus-1/system.d

Description Philip Withnall 2017-02-22 13:24:32 UTC
Minor patch to mention /usr/share/dbus-1/system.d as well as /etc/dbus-1/system.d in the documentation. Similarly for session.d.
Comment 1 Philip Withnall 2017-02-22 13:24:35 UTC
Created attachment 129825 [details] [review]
doc: Clarify /etc/dbus-1/system.d and /usr/share/dbus-1/system.d

The documentation generally only mentioned the directory in /etc, even
though we actually prefer security policies to be installed in
/usr/share to allow for stateless and volatile systems (i.e. booting up
with an empty /etc).

Signed-off-by: Philip Withnall <withnall@endlessm.com>
Comment 2 Simon McVittie 2017-02-22 15:17:32 UTC
Comment on attachment 129825 [details] [review]
doc: Clarify /etc/dbus-1/system.d and /usr/share/dbus-1/system.d

Review of attachment 129825 [details] [review]:
-----------------------------------------------------------------

::: doc/dbus-api-design.duck
@@ +839,5 @@
>  security policy, and consider splitting up methods or providing more restricted
>  versions which accept constrained parameters, so that they can be exposed with
> +less restrictive security policies if needed by less trusted clients. Security
> +policies should be installed to $file($var($$(datadir$))) rather than
> +$(file($var($$(sysconfdir$))); the latter is intended for system administators.

It might be worth saying "Since dbus-daemon 1.10, security policies should..." since this is a relatively recent addition (you can't rely on it in something like Debian stable or RHEL).
Comment 3 Philip Withnall 2017-02-22 16:37:47 UTC
Created attachment 129829 [details] [review]
doc: Clarify /etc/dbus-1/system.d and /usr/share/dbus-1/system.d

The documentation generally only mentioned the directory in /etc, even
though we actually prefer security policies to be installed in
/usr/share to allow for stateless and volatile systems (i.e. booting up
with an empty /etc).

Signed-off-by: Philip Withnall <withnall@endlessm.com>
Comment 4 Simon McVittie 2017-02-23 13:12:34 UTC
Comment on attachment 129829 [details] [review]
doc: Clarify /etc/dbus-1/system.d and /usr/share/dbus-1/system.d

Review of attachment 129829 [details] [review]:
-----------------------------------------------------------------

Looks good
Comment 5 Simon McVittie 2017-02-24 18:35:36 UTC
Fixed in git for 1.11.12, thanks

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.