| Summary: | pdfimages does not save 16bpc bitmaps | ||
|---|---|---|---|
| Product: | poppler | Reporter: | Brecht Machiels <brecht> |
| Component: | utils | Assignee: | poppler-bugs <poppler-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
PDF with 16 bpc bitmap
16 bpc tiff image support 16 bpc png and tiff image support |
||
|
Description
Brecht Machiels
2017-02-27 17:55:20 UTC
We need a sample PDF with a 16 bpc image. Created attachment 129977 [details]
PDF with 16 bpc bitmap
$ pdfimages -list basn2c16_device.pdf page num type width height color comp bpc enc interp object ID x-ppi y-ppi size ratio -------------------------------------------------------------------------------------------- 1 0 image 32 32 rgb 3 16 image no 4 0 72 72 229B 3.7% $ pdfimages basn2c16_device.pdf basn2c16_device $ identify basn2c16_device-000.ppm basn2c16_device-000.ppm PPM 32x32 32x32+0+0 8-bit sRGB 3.08KB 0.000u 0:00.000 $ pdfimages -all basn2c16_device.pdf basn2c16_device $ identify basn2c16_device-000.png basn2c16_device-000.png PNG 32x32 32x32+0+0 8-bit sRGB 237B 0.000u 0:00.000 Created attachment 129996 [details] [review] 16 bpc tiff image support Created attachment 129997 [details] [review] 16 bpc png and tiff image support Adrian, looks good to me, please commit.
I'd personally prefer if you moved the Gushort *rowp16; declaration inside the case, I know poppler mostly doesn't use that style but i appreciate vars being declarated in the smalled scope possible (you may actually need to add some {})
I've moved the declaration to to case statement. Pushed. Thanks Adrian! |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.