Bug 43619 - Animating only 2nd level paragraphs hides 1st level paragraphs
Summary: Animating only 2nd level paragraphs hides 1st level paragraphs
Status: REOPENED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Presentation (show other bugs)
Version: 3.4 Daily
Hardware: Other All
: medium normal
Assignee: Not Assigned
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-08 00:08 UTC by Stephan Bergmann
Modified: 2012-07-05 07:11 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
sample document (13.05 KB, application/vnd.oasis.opendocument.presentation)
2011-12-08 00:08 UTC, Stephan Bergmann
Details
fix the (automatically selected) paragraph grouping (2.15 KB, text/plain)
2011-12-08 00:16 UTC, Stephan Bergmann
Details

Description Stephan Bergmann 2011-12-08 00:08:15 UTC
Created attachment 54217 [details]
sample document

See the attached fly.odp with a text box with three 1st level paragraphs (Foo, Bar, Baz) with one 2nd level paragraph each (First, Second, Third), with an on-click animation (fly in) grouped "By 2nd level paragraphs" (see context menu of any of the items in the "Tasks" pane's "Custom Animation - Effect Fly In" list, "Effect Options... - Text Animation - Group text").

When doing the slide show, the individual 1st and 2nd level paragraphs correctly fly in one by one (Foo; First; Bar; Second; Baz; Third).

Now, remove the effect for each of the 1st level paragraphs (Foo, Bar, Baz), via the items' context menu "Remove".  When doing the slide show, the first 1st level paragraph (Foo) is correctly displayed right from the start, and the individual 2nd level paragraphs correctly fly in one by one (First; Second; Third), but the remaining two 1st level paragraphs (Bar, Baz) are erroneously not displayed at all.

Also, after removing all the 1st level paragraphs' effects, the grouping of the remaining 2nd level paragraphs (as stated at "Effect Options... - Text Animation -Group Text") changes from "By 2nd level paragraphs" to "All paragraphs at once".  Manually changing the setting for a paragraph does not work, after closing the "Effect Options" dialog it automatically goes back to "All paragraph at once."

(Reproduced with a libreoffice-3-4 build towards LO 3.4.5.  On master towards LO 3.5, this cannot currently be tested well, as doing this animated slide show, at least in an unxlngx6 --enable-dbgutil build, soffice.bin aborts with drawshapesubsetting.cxx's makeTreeNode calculating std::distance between singular iterator and end; immediate problem appears to be that maActionClassVector.begin() == maActionClassVector.end() in DrawShapeSubsetting::getTreeNode.)
Comment 1 Stephan Bergmann 2011-12-08 00:16:22 UTC
Created attachment 54218 [details]
fix the (automatically selected) paragraph grouping

With the attached paralevels.patch, after removing all the 1st level paragraphs' effects, the grouping of the remaining 2nd level paragraphs (as stated at "Effect Options... - Text Animation -Group Text") stays at "By 2nd level paragraphs" and no longer automatically changes to "All paragraphs at once".  Manually changing the setting for a paragraph still does not work, however---after closing the "Effect Options" dialog it automatically goes back to "By 2nd level paragraphs."
Comment 2 Michael Meeks 2012-05-08 13:10:14 UTC
Thorsten ? :-)
Comment 3 Not Assigned 2012-05-08 15:17:33 UTC
Stephan Bergmann committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=5c2c03e9062d0c86d385a56c3ce1f536944927a2

Fix fdo#43619 Animating only 2nd level paragraphs hides 1st level
Comment 4 Thorsten Behrens 2012-05-08 15:18:12 UTC
Patch looks good, improves things -> pushed.
Comment 5 Stephan Bergmann 2012-05-09 01:01:32 UTC
But the original problem is not yet fixed at all.

Note that attachment 54218 [details] was nothing but work-in-progress, as comment 1 tried to make clear.  It now unfortunately got committed with a misleading commit message claiming "Fix fdo#43619."
Comment 6 Michael Stahl 2012-07-05 07:11:41 UTC
Comment on attachment 54218 [details]
fix the (automatically selected) paragraph grouping

patch is integrated, removing "patch" flag so it does not turn
up in bugzilla searches.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.