Bug 46399 - EasyHack: vcl - cleanup empty methods ...
Summary: EasyHack: vcl - cleanup empty methods ...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Libreoffice (show other bugs)
Version: Master old -3.6
Hardware: Other All
: medium normal
Assignee: Greggory Hernandez
QA Contact:
URL:
Whiteboard: EasyHack,DifficultyBeginner,SkillCpp,...
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-21 08:13 UTC by Michael Meeks
Modified: 2012-02-22 01:43 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
Consolidate empty methods (9.75 KB, patch)
2012-02-21 19:54 UTC, Greggory Hernandez 		Details | Splinter Review
View All

Description Michael Meeks 2012-02-21 08:13:29 UTC 
The vcl/inc/salobj.hxx interface is implemented by several platform backends but many of these use the same (empty) implementations for several of the methods eg.

'GrabFocus', 'SetBackround', and 'Enable'

it'd be great to have an empty default in the parent implementation instead, and remove all those dummy overrides in the headers and implementations.

It is possible that a few similar cases exist for other backend classes too.

Thanks :-)
Comment 1 Greggory Hernandez 2012-02-21 19:54:57 UTC 
Created attachment 57430 [details] [review]
Consolidate empty methods

I've sent this to the mailing list as well.
Comment 2 Michael Meeks 2012-02-22 01:41:59 UTC 
thanks ! :-)
Comment 3 Not Assigned 2012-02-22 01:43:05 UTC 
Greggory Hernandez committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=f1cf3d1d6a18af079f8afd0b18be5b15b043948e

vcl: fdo#46399 cleanup and share dummy virtual methods ...

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.