Bug 60906 - Make color configuration consistent
Summary: Make color configuration consistent
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Libreoffice (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Not Assigned
QA Contact:
URL:
Whiteboard: EasyHack SkillCpp target:4.4.0
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-15 15:32 UTC by Thomas Arnhold
Modified: 2014-11-05 09:33 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Thomas Arnhold 2013-02-15 15:32:53 UTC
There are some inconsistencies within the color configuration. Some of them are uncovered and fixed already. See bug#59042 and bug#51535.

Problem is, that two lists of default colors exist:

ColorConfig::GetDefaultColor

http://opengrok.libreoffice.org/xref/core/svtools/source/config/colorcfg.cxx#407

ImplStyleData::SetStandardStyles

http://opengrok.libreoffice.org/xref/core/vcl/source/app/settings.cxx#389

Those lines point to APPBACKGROUND where's a difference in the settings. Another example is LINKVISITED.

Tasks: As a first step compare both lists and bring them into compliance.

Afterwards it would be nice to drop one of both lists. Kendy stated in a mail that it would be colorcfg.cxx:

> So it would be nice to align both lists. And to remove some more 
> inconsistencies. Maybe SetStandardStyles is some kind of outdated?!

This is a great point - I already wanted to do that at some stage, but
then forgot :-(  Please go ahead - I'd like colorcfg.cxx and related
die, and handle everything in vcl, there is really no point in
maintaining 2 lists; but still some distinction between "default" and
"configured by user" will have to stay even we consolidate the lists.
Comment 1 Björn Michaelsen 2013-10-04 18:46:50 UTC
adding LibreOffice developer list as CC to unresolved EasyHacks for better visibility.

see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for details
Comment 2 Commit Notification 2014-11-05 09:33:58 UTC
Ioan Radu committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=6cc8ed7d64b4c01550539170c1848f1152e433af

fdo#60906 - Make color configuration consistent

It will be available in 4.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.