Bug 20908 - Observer: [impl needed] ObserveChannels should also take a Channel_Request[]
Summary: Observer: [impl needed] ObserveChannels should also take a Channel_Request[]
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-spec (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/sm...
Whiteboard:
Keywords: patch
Depends on: 20909
Blocks: 21148
  Show dependency treegraph
 
Reported: 2009-03-27 07:59 UTC by Simon McVittie
Modified: 2009-04-14 07:54 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Simon McVittie 2009-03-27 07:59:08 UTC
When ObserveChannels() is called on an observer C which is also a Handler, it
can't tell if those channels satisfy a request it knows about.

* AddRequest() is called on a client C (because it, or something else,
requested a channel).
* C opens a tab or similar to represent the ongoing request.
* The channel appears. MC calls ObserveChannels() on all matching clients,
including C.
* C doesn't know that the new channel relates to the ongoing request; it opens
a new UI element for it.
* Now HandleChannels() is called, including the channel and the requests it
satisfies. Only now can C tell that the channel referred to that request.

The obvious fix is to add ao: Requests_Satisfied to ObserveChannels(), just as
the related ChannelDispatchOperation is already a parameter to
ObserveChannels().
Comment 2 Simon McVittie 2009-04-14 07:54:15 UTC
Merged in git and will be in 0.17.23, but still needs implementation


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.