Bug 20909 - [pending API break] Observer: add parameters to ObserveChannels
Summary: [pending API break] Observer: add parameters to ObserveChannels
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: mission-control (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/sm...
Whiteboard:
Keywords: patch
Depends on:
Blocks: 20908 21148
  Show dependency treegraph
 
Reported: 2009-03-27 08:19 UTC by Simon McVittie
Modified: 2009-04-28 05:46 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Simon McVittie 2009-03-27 08:19:33 UTC
ObserveChannels() is meant to take a ChannelDispatchOperation parameter, but MC does not implement this version.
Comment 1 Simon McVittie 2009-04-14 07:19:29 UTC
We should skip straight past the current spec and implement the one from Bug #20908.
Comment 2 Simon McVittie 2009-04-17 08:46:48 UTC
Implemented in my observer-20909 branch, commit ba751fc3a, with an additional patch in my break-api branch to actually make it active.
Comment 3 Simon McVittie 2009-04-17 09:28:59 UTC
Implementation:

http://git.collabora.co.uk/?p=user/smcv/telepathy-mission-control-smcv.git;a=shortlog;h=refs/heads/observer-20909-break-api

I believe the part up to observer-20909 can safely be merged right now.
Comment 4 Simon McVittie 2009-04-20 02:09:44 UTC
All approved by mardy, merge to follow as part of a coordinated API break.
Comment 5 Simon McVittie 2009-04-28 05:46:22 UTC
Was fixed in 5.0.beta68


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.