mesa: 78ee8b3f849063e3e37db0767212397da522b6fa (master 17.1.0-devel) ==================================================== Mesa 17.1.0-devel: src/compiler/test-suite.log ==================================================== # TOTAL: 10 # PASS: 9 # SKIP: 0 # XFAIL: 0 # FAIL: 1 # XPASS: 0 # ERROR: 0 .. contents:: :depth: 2 FAIL: glsl/tests/optimization-test.sh
Created attachment 130526 [details] Test suite log This happens for me since commit 86a937d2644a ("glsl/tests/optimization-test: correctly manage srcdir/builddir"), but AFAICT before that the lower_jumps tests just didn't get generated at all for out-of-tree builds. So one would need to use an in-tree build to find the original regression point.
Note that I was seeing different intermittent failures with earlier commits, which make clean resolved.
Bisecting with an in-tree build identified the same commit as the culprit. Emil, any ideas?
Po(In reply to Michel Dänzer from comment #1) > Created attachment 130526 [details] > Test suite log > > This happens for me since commit 86a937d2644a > ("glsl/tests/optimization-test: correctly manage srcdir/builddir"), but > AFAICT before that the lower_jumps tests just didn't get generated at all > for out-of-tree builds. So one would need to use an in-tree build to find > the original regression point. Was it getting generated for in-tree builds? I fixed a bug with lower jumps recently, I wonder if that has change the output the test is expecting. https://cgit.freedesktop.org/mesa/mesa/commit/?id=c1096b7f1d49f33c85b1042f82ccb063f63e7c20
Good catch, yes that commit broke it.
This updates the test to reflect the new IR: https://patchwork.freedesktop.org/patch/147012/
Fixed by: commit e44cba540ee7a07bba643bab4b9e519e90244bd1 Author: Timothy Arceri <tarceri@itsqueeze.com> Date: Wed Mar 29 20:30:19 2017 +1100 mesa: update lower_jumps tests after bug fix This change updates the tests to reflect the IR after the following bug fix. Fixes: c1096b7f1d49 ("glsl: fix lower jumps for returns when loop is inside an if") Tested-by: Michel Dänzer <michel.daenzer@amd.com> Bugzilla: https://bugs.freedesktop.org/100441
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.