Attachment 102089 Details for Bug 80767 – 0001-Fix-a-possible-NULL-dereference.patch

[patch] 0001-Fix-a-possible-NULL-dereference.patch

0001-Fix-a-possible-NULL-dereference.patch (text/plain), 1.59 KB, created by Miloslav Trmac on 2014-07-01 18:49:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Miloslav Trmac

Created: 2014-07-01 18:49:56 UTC

Size: 1.59 KB

patch

obsolete

>From 83b5bc967e77e4b155b1773d102c730ec112afee Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Miloslav=20Trma=C4=8D?= <mitr@redhat.com>
>Date: Wed, 11 Jun 2014 22:36:50 +0200
>Subject: [PATCH 1/5] Fix a possible NULL dereference.
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>polkit_backend_session_monitor_get_user_for_subject() may return NULL
>(and because it is using external processes, we canât really rule it
>out).  The code was already anticipating NULL in the cleanup section, so
>handle it also when actually using the value.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=80767
>---
> src/polkitbackend/polkitbackendinteractiveauthority.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/src/polkitbackend/polkitbackendinteractiveauthority.c b/src/polkitbackend/polkitbackendinteractiveauthority.c
>index 59028d5..0445148 100644
>--- a/src/polkitbackend/polkitbackendinteractiveauthority.c
>+++ b/src/polkitbackend/polkitbackendinteractiveauthority.c
>@@ -559,7 +559,11 @@ log_result (PolkitBackendInteractiveAuthority    *authority,
>   user_of_subject = polkit_backend_session_monitor_get_user_for_subject (priv->session_monitor, subject, NULL);
> 
>   subject_str = polkit_subject_to_string (subject);
>-  user_of_subject_str = polkit_identity_to_string (user_of_subject);
>+
>+  if (user_of_subject != NULL)
>+    user_of_subject_str = polkit_identity_to_string (user_of_subject);
>+  else
>+    user_of_subject_str = g_strdup ("<unknown>");
>   caller_str = polkit_subject_to_string (caller);
> 
>   subject_cmdline = _polkit_subject_get_cmdline (subject);
>-- 
>1.8.3.1
>

Actions: View | Splinter Review

Attachments on bug 80767: 102089 | 102090 | 102091 | 102092 | 102093

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.