... just because I’m compulsive about a clean build. This series fixes various Coverity- and Eclipse- reported problems and ugliness. (Can easily enough wait after the next release.)
Created attachment 102089 [details] [review] 0001-Fix-a-possible-NULL-dereference.patch
Created attachment 102090 [details] [review] 0002-Remove-a-redundant-assignment.patch
Created attachment 102091 [details] [review] 0003-Explicitly-cast-a-no-effect-reference-to-void.patch
Created attachment 102092 [details] [review] 0004-Fix-a-typo-s-Evaluting-Evaluating-g.patch
Created attachment 102093 [details] [review] 0005-s-INCLUDES-AM_CPPFLAGS-g.patch
Comment on attachment 102089 [details] [review] 0001-Fix-a-possible-NULL-dereference.patch Review of attachment 102089 [details] [review]: ----------------------------------------------------------------- LGTM
Comment on attachment 102090 [details] [review] 0002-Remove-a-redundant-assignment.patch Review of attachment 102090 [details] [review]: ----------------------------------------------------------------- Right.
Comment on attachment 102091 [details] [review] 0003-Explicitly-cast-a-no-effect-reference-to-void.patch Review of attachment 102091 [details] [review]: ----------------------------------------------------------------- I think I'd be more in favor of the (void) POLKIT_ERROR; but it's up to you if you want to redo it or just commit as is.
Comment on attachment 102092 [details] [review] 0004-Fix-a-typo-s-Evaluting-Evaluating-g.patch Review of attachment 102092 [details] [review]: ----------------------------------------------------------------- Yes.
Comment on attachment 102093 [details] [review] 0005-s-INCLUDES-AM_CPPFLAGS-g.patch Review of attachment 102093 [details] [review]: ----------------------------------------------------------------- Yep.
Thanks, fixed. Went with (void) POLKIT_ERROR; instead of patch 3.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.