Attachment 105365 Details for Bug 83148 – u_vbuf: Make sure all caps are initialized

[patch] u_vbuf: Make sure all caps are initialized

0001-u_vbuf-Make-sure-all-caps-are-initialized.patch (text/plain), 2.30 KB, created by Michel Dänzer on 2014-08-28 02:21:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michel Dänzer

Created: 2014-08-28 02:21:57 UTC

Size: 2.30 KB

patch

obsolete

>From 137925ac474e1f3eaac7df31250c93def289412a Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Michel=20D=C3=A4nzer?= <michel.daenzer@amd.com>
>Date: Thu, 28 Aug 2014 11:12:20 +0900
>Subject: [PATCH] u_vbuf: Make sure all caps are initialized
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Pointed out by valgrind.
>
>Signed-off-by: Michel DÃ¤nzer <michel.daenzer@amd.com>
>---
> src/gallium/auxiliary/util/u_vbuf.c | 40 +++++++++++++++----------------------
> 1 file changed, 16 insertions(+), 24 deletions(-)
>
>diff --git a/src/gallium/auxiliary/util/u_vbuf.c b/src/gallium/auxiliary/util/u_vbuf.c
>index 4bee899..650df9f 100644
>--- a/src/gallium/auxiliary/util/u_vbuf.c
>+++ b/src/gallium/auxiliary/util/u_vbuf.c
>@@ -279,30 +279,22 @@ boolean u_vbuf_get_caps(struct pipe_screen *screen, struct u_vbuf_caps *caps)
>       }
>    }
> 
>-   if (!screen->get_param(screen,
>-                          PIPE_CAP_VERTEX_BUFFER_OFFSET_4BYTE_ALIGNED_ONLY)) {
>-      caps->buffer_offset_unaligned = TRUE;
>-   } else {
>-      fallback = TRUE;
>-   }
>-
>-   if (!screen->get_param(screen,
>-                          PIPE_CAP_VERTEX_BUFFER_STRIDE_4BYTE_ALIGNED_ONLY)) {
>-      caps->buffer_stride_unaligned = TRUE;
>-   } else {
>-      fallback = TRUE;
>-   }
>-
>-   if (!screen->get_param(screen,
>-                          PIPE_CAP_VERTEX_ELEMENT_SRC_OFFSET_4BYTE_ALIGNED_ONLY)) {
>-      caps->velem_src_offset_unaligned = TRUE;
>-   } else {
>-      fallback = TRUE;
>-   }
>-
>-   if (screen->get_param(screen, PIPE_CAP_USER_VERTEX_BUFFERS)) {
>-      caps->user_vertex_buffers = TRUE;
>-   } else {
>+   caps->buffer_offset_unaligned =
>+      !screen->get_param(screen,
>+                         PIPE_CAP_VERTEX_BUFFER_OFFSET_4BYTE_ALIGNED_ONLY);
>+   caps->buffer_stride_unaligned =
>+     !screen->get_param(screen,
>+                        PIPE_CAP_VERTEX_BUFFER_STRIDE_4BYTE_ALIGNED_ONLY);
>+   caps->velem_src_offset_unaligned =
>+      !screen->get_param(screen,
>+                         PIPE_CAP_VERTEX_ELEMENT_SRC_OFFSET_4BYTE_ALIGNED_ONLY);
>+   caps->user_vertex_buffers =
>+      screen->get_param(screen, PIPE_CAP_USER_VERTEX_BUFFERS);
>+
>+   if (!caps->buffer_offset_unaligned ||
>+       !caps->buffer_stride_unaligned ||
>+       !caps->velem_src_offset_unaligned ||
>+       !caps->user_vertex_buffers) {
>       fallback = TRUE;
>    }
> 
>-- 
>2.1.0
>

Actions: View | Splinter Review

Attachments on bug 83148: 105337 | 105338 | 105339 | 105340 | 105341 | 105350 | 105365

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.