Attachment 10755 Details for Bug 11226 – quickly check if some mandatory exa driver hooks are missing

[patch] quickly check if some mandatory exa driver hooks are missing

basic-exa-entry-point-validation.patch (text/plain), 2.25 KB, created by Dodji Seketeli on 2007-07-16 08:42:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dodji Seketeli

Created: 2007-07-16 08:42:05 UTC

Size: 2.25 KB

patch

obsolete

>commit 73f007386e06eb684a326c0d504f029368c6bdec
>Author: Dodji Seketeli <dodji@seketeli.org>
>Date:   Mon Jul 16 17:37:21 2007 +0200
>
>    Add basic Exa driver entry point validation.
>    
>    In exaDriverInit(), quickly check if the programmer forgot to set some
>    mandadory driver hooks, in that case display a meaningful error message.
>
>diff --git a/exa/exa.c b/exa/exa.c
>index c5b5a66..862e83b 100644
>--- a/exa/exa.c
>+++ b/exa/exa.c
>@@ -550,6 +550,48 @@ exaDriverAlloc(void)
>     return xcalloc(1, sizeof(ExaDriverRec));
> }
> 
>+static Bool
>+exaDriverValidateEntryPoints (ExaDriverPtr  pExaDriver)
>+{
>+    Bool res=TRUE ;
>+
>+    if (!pExaDriver)
>+        return FALSE ;
>+
>+    if (!pExaDriver->memoryBase) {
>+        LogMessage(X_ERROR,
>+                   "Exa: Exa::memoryBase member "
>+                   "must be assigned to a value different from zero\n") ;
>+        res = FALSE ;
>+    }
>+    if (!pExaDriver->memorySize) {
>+        LogMessage(X_ERROR,
>+                   "Exa: Exa::memorySize member must be different from zero\n") ;
>+        res = FALSE ;
>+    }
>+    if (pExaDriver->offScreenBase > pExaDriver->memorySize) {
>+        LogMessage(X_ERROR,
>+                   "Exa: Exa::ffscreenBase must be <= pExaDriver->memorySize member\n") ;
>+        res = FALSE ;
>+    }
>+    if (!pExaDriver->PrepareSolid) {
>+        LogMessage(X_ERROR,
>+                   "Exa: Exa::PrepareSolid member is required to be non NULL\n") ;
>+        res = FALSE ;
>+    }
>+    if (!pExaDriver->PrepareCopy) {
>+        LogMessage(X_ERROR,
>+                   "Exa: Exa::PrepareCopy member is required to be non NULL\n") ;
>+        res = FALSE ;
>+    }
>+    if (!pExaDriver->WaitMarker) {
>+        LogMessage(X_ERROR,
>+                   "Exa: Exa::WaitWarker member is required to be non NULL\n") ;
>+        res = FALSE ;
>+    }
>+    return res ;
>+}
>+
> /**
>  * @param pScreen screen being initialized
>  * @param pScreenInfo EXA driver record
>@@ -579,6 +621,12 @@ exaDriverInit (ScreenPtr		pScreen,
> 		   EXA_VERSION_MAJOR, EXA_VERSION_MINOR);
> 	return FALSE;
>     }
>+    if (!exaDriverValidateEntryPoints(pScreenInfo))
>+    {
>+	LogMessage(X_ERROR, "Exa(%d): EXA driver entry points validation failed\n",
>+		   pScreen->myNum) ;
>+	return FALSE ;
>+    }
> 
> #ifdef RENDER
>     ps = GetPictureScreenIfSet(pScreen);

Actions: View | Splinter Review

Attachments on bug 11226: 10248 | 10755

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.