Bug 11226 - crash when Exa:MarkSync function is set to NULL
Summary: crash when Exa:MarkSync function is set to NULL
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/Acceleration/EXA (show other bugs)
Version: 7.2 (2007.02)
Hardware: Other All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-11 00:44 UTC by Dodji Seketeli
Modified: 2007-07-17 03:22 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
fixes a crash when the Exa:WaitSync function pointer is set to NULL (692 bytes, patch)
2007-06-11 00:46 UTC, Dodji Seketeli 		no flags Details | Splinter Review
quickly check if some mandatory exa driver hooks are missing (2.25 KB, patch)
2007-07-16 08:42 UTC, Dodji Seketeli 		no flags Details | Splinter Review
View All

Description Dodji Seketeli 2007-06-11 00:44:50 UTC 
When using the exa layer, if the Exa:MarkSync function is set to NULL, the server crashes.
Comment 1 Dodji Seketeli 2007-06-11 00:46:03 UTC 
Created attachment 10248 [details] [review]
fixes a crash when the Exa:WaitSync function pointer is set to NULL
Comment 2 Michel Dänzer 2007-06-11 01:19:55 UTC 
See exa.h: 'WaitMarker() is required of all drivers.'
Comment 3 Michel Dänzer 2007-06-11 01:22:28 UTC 
That said, a better solution might be for exaDriverInit to check this and fail if it's missing.
Comment 4 Dodji Seketeli 2007-06-11 01:26:43 UTC 
Okay. I have seen that it was required, but I don't think that crashing is an acceptable answer anyway.

I like your proposal of checking that in the exa initialization.
Would you accept a patch for that ? If yes, then could we re-open the bug or open another one until the patch is applied ?

Thanks.
Comment 5 Michel Dänzer 2007-06-11 01:29:59 UTC 
An exaDriverInit patch should be acceptable.
Comment 6 Dodji Seketeli 2007-06-11 01:38:42 UTC 
Okay, thanks.

I will work on it then.
Comment 7 Dodji Seketeli 2007-07-16 08:42:05 UTC 
Created attachment 10755 [details] [review]
quickly check if some mandatory exa driver hooks are missing

This patch just quickly checks during exa init if some of the mandatory driver hooks are missing.
Comment 8 Michel Dänzer 2007-07-17 03:22:03 UTC 
Pushed with cosmetic fixups as commit 5657fb065cc79ba3ca5a836f45637ba9894f9abf, thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.