Attachment 110313 Details for Bug 86683 – Revert infoframe check

[patch] Revert infoframe check

patch (text/plain), 1.42 KB, created by Jesse Barnes on 2014-12-01 17:55:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jesse Barnes

Created: 2014-12-01 17:55:24 UTC

Size: 1.42 KB

patch

obsolete

>commit e80378b3edb6200874f8c97865f66e75bc11f223
>Author: Jesse Barnes <jbarnes@virtuousgeek.org>
>Date:   Mon Dec 1 09:52:45 2014 -0800
>
>    drm/i915: don't always do full mode sets when infoframes are enabled
>    
>    Partial revert of
>    
>    commit 206645910b9796bff13fcdb67bdca166b724ba62
>    Author: Jesse Barnes <jbarnes@virtuousgeek.org>
>    Date:   Wed Nov 5 14:26:09 2014 -0800
>    
>        drm/i915: check for audio and infoframe changes across mode sets v2
>    
>    References: https://bugs.freedesktop.org/show_bug.cgi?id=86683
>    Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
>
>diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
>index 42bcbea..fe27a2c 100644
>--- a/drivers/gpu/drm/i915/intel_display.c
>+++ b/drivers/gpu/drm/i915/intel_display.c
>@@ -11601,10 +11601,12 @@ static int intel_crtc_set_config(struct drm_mode_set *set)
> 		    to_intel_crtc(set->crtc)->config.has_audio)
> 			config->mode_changed = true;
> 
>-		/* Force mode sets for any infoframe stuff */
>-		if (pipe_config->has_infoframe ||
>-		    to_intel_crtc(set->crtc)->config.has_infoframe)
>-			config->mode_changed = true;
>+		/*
>+		 * Note we have an issue here with infoframes: current code
>+		 * only updates them on the full mode set path per hw
>+		 * requirements.  So here we should be checking for any
>+		 * required changes and forcing a mode set.
>+		 */
> 	}
> 
> 	/* set_mode will free it in the mode_changed case */

Actions: View | Splinter Review

Attachments on bug 86683: 109981 | 110313

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.