Bug 86683 - [BSW Bisected] HDMI screen goes black for a while when run testdisplay -i
Summary: [BSW Bisected] HDMI screen goes black for a while when run testdisplay -i
Status: CLOSED FIXED
Alias: None
Product: DRI
Classification: Unclassified
Component: DRM/Intel (show other bugs)
Version: XOrg git
Hardware: Other All
: high major
Assignee: Jesse Barnes
QA Contact: Intel GFX Bugs mailing list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-25 06:21 UTC by Li Xu
Modified: 2017-10-06 14:33 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
dmesg (123.62 KB, text/plain)
2014-11-25 06:21 UTC, Li Xu 		no flags Details
Revert infoframe check (1.42 KB, patch)
2014-12-01 17:55 UTC, Jesse Barnes 		no flags Details | Splinter Review
View All

Description Li Xu 2014-11-25 06:21:22 UTC 
Created attachment 109981 [details]
dmesg

Environment:
--------------------------
Platform: BSW
Kernel: (drm-intel-nightly) 2014_11_25 ab4b258a6ea5f58b5cb17131aced8f9a8dd64499

Bug detailed description:
-----------------------------
We boot up the machine with HDMI ,and then run testdisplay -i, screen will goes black for a while and then light up again. 

Steps:
---------------------------
Boot up with HDMI
./testdisplay -i
Comment 1 Daniel Vetter 2014-11-25 08:41:55 UTC 
Please supply the bisect result, thanks.
Comment 2 Li Xu 2014-12-01 09:37:39 UTC 
Bisect result:

206645910b9796bff13fcdb67bdca166b724ba62 is the first bad commit
commit 206645910b9796bff13fcdb67bdca166b724ba62
Author: Jesse Barnes <jbarnes@virtuousgeek.org>
Date:   Wed Nov 5 14:26:09 2014 -0800

    drm/i915: check for audio and infoframe changes across mode sets v2

    If these change (e.g. after a modeset following a fastboot), we need to
    do a full mode set.

    v2:
      - put under pipe_config check so we don't deref a null state (Jesse)

    Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
    Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Comment 3 Jani Nikula 2014-12-01 10:23:42 UTC 
(In reply to Li Xu from comment #2)
> Bisect result:

Please always assign bug to regressing commit's author. Done now. Thanks.
Comment 4 Jesse Barnes 2014-12-01 17:55:24 UTC 
Created attachment 110313 [details] [review]
Revert infoframe check

Can you check this patch and see if it helps?
Comment 5 Yi Sun 2014-12-02 00:33:35 UTC 
(In reply to Jesse Barnes from comment #4)
> Created attachment 110313 [details] [review] [review]
> Revert infoframe check
> 
> Can you check this patch and see if it helps?

Jesse, remember changing the bug status to ‘Needinfo', which prevents QA missing it. :)
Comment 6 Li Xu 2014-12-02 09:20:12 UTC 
This patch works well.
Comment 7 Jesse Barnes 2014-12-04 20:59:23 UTC 
Great, thanks for testing, we'll get the revert integrated.
Comment 8 Jani Nikula 2014-12-08 12:38:15 UTC 
commit af15d2ce5d497ba6535dead782cfadbcc83d90fe
Author: Jesse Barnes <jbarnes@virtuousgeek.org>
Date:   Mon Dec 1 09:54:28 2014 -0800

    drm/i915: don't always do full mode sets when infoframes are enabled
Comment 9 Li Xu 2014-12-09 09:37:03 UTC 
Yes ,it works well on -nightly latest.
Comment 10 Elizabeth 2017-10-06 14:33:28 UTC 
Closing old verified.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.