Attachment 116340 Details for Bug 90888 – Candidate patch

Candidate patch

0001-nv50-OP_JOIN-is-a-flow-instruction.patch (text/plain), 1.09 KB, created by jr on 2015-06-07 19:51:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: jr

Created: 2015-06-07 19:51:05 UTC

Size: 1.09 KB

patch

obsolete

>From a2f60fa5dba2d47450a2525b210729f44593ca25 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?J=C3=BCrgen=20R=C3=BChle?= <j-r@online.de>
>Date: Sat, 6 Jun 2015 18:37:20 +0200
>Subject: [PATCH 1/2] nv50: OP_JOIN is a flow instruction
>
>OP_JOIN instructions are assumed to be flow instructions and mercilessly
>casted to FlowInstruction.
>
>This patch fixes an instance where an OP_JOIN is created as a plain
>instruction. This can cause crashes in the ir printer.
>---
> src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nv50.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nv50.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nv50.cpp
>index 1ad0860..b412727 100644
>--- a/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nv50.cpp
>+++ b/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nv50.cpp
>@@ -887,7 +887,7 @@ NV50LoweringPreSSA::handleTXL(TexInstruction *i)
>       }
>    }
>    bld.setPosition(joinBB, false);
>-   bld.mkOp(OP_JOIN, TYPE_NONE, NULL);
>+   bld.mkFlow(OP_JOIN, NULL, CC_ALWAYS, NULL);
>    return true;
> }
> 
>-- 
>2.1.4
>

Actions: View

Attachments on bug 90888: 116340

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.