Bug 90888 - A trivial fix for a potential crash
Summary: A trivial fix for a potential crash
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/nouveau (show other bugs)
Version: git
Hardware: All All
: medium trivial
Assignee: Nouveau Project
QA Contact: Nouveau Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-07 19:51 UTC by jr
Modified: 2015-06-15 15:53 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Candidate patch (1.09 KB, text/plain)
2015-06-07 19:51 UTC, jr
Details

Description jr 2015-06-07 19:51:05 UTC
Created attachment 116340 [details]
Candidate patch

OP_JOIN are static casted to FlowInstruction, but handleTXL creates OP_JOIN that is no FlowInstruction.

It probably doesn't matter outside debug builds, since only the IR printer seems to access the additional FlowInstruction fields.
Comment 1 Ilia Mirkin 2015-06-07 20:26:14 UTC
Great patch. Please mail it out to nouveau@lists.freedesktop.org, these things are usually just done over email when there's no real bug to keep track of. One small thing is I normally use "nv50/ir" prefix when modifying stuff in codegen.

I'm away from computers where I can check this out for another week or so, but I'll be able to take a detailed look then. [And your other bug too.]
Comment 2 Ilia Mirkin 2015-06-15 15:53:24 UTC
Hrmph.... one small difference is that mkOp() appears to set the instruction with ->fixed = 1. I'm adding that in just in case it mattered in this case... Converter::insertConvergenceOps seems to do this too. Now pushed. In the future, you can just mail patches to nouveau@lists.freedesktop.org and/or mesa-dev@lists.freedesktop.org.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.