Attachment 119950 Details for Bug 92979 – client-info: Don't load props of /org/freedesktop/DBus

[patch] client-info: Don't load props of /org/freedesktop/DBus

client-info-Dont-load-props-of-orgfreedesktopDBus.patch (text/plain), 1.58 KB, created by Zeeshan Ali on 2015-11-19 19:08:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Zeeshan Ali

Created: 2015-11-19 19:08:32 UTC

Size: 1.58 KB

patch

obsolete

>From 45593fe88e9aabcd26fc610dc3963326ed662936 Mon Sep 17 00:00:00 2001
>From: Tristan Van Berkom <tristan.vanberkom@codethink.co.uk>
>Date: Tue, 17 Nov 2015 18:23:47 +0900
>Subject: [PATCH] client-info: Don't load props of /org/freedesktop/DBus
>
>By default, glib's GDBusProxy calls org.freedesktop.DBus.Properties.GetAll
>to load all properties on a loaded interface - however in this case we
>are creating a proxy to the system standard bus interface for the sole
>purpose of later calling GetConnectionUnixUser.
>
>GeoClue does not have permission to use the org.freedesktop.DBus.Properties
>interface on a proxy to /org/freedesktop/DBus (and there are no properties
>to be loaded anyway).
>
>Note that GeoClue works fine without this patch, however this patch
>will avoid error messages being logged to the system logs.
>
>https://bugs.freedesktop.org/show_bug.cgi?id=92979
>---
> src/gclue-client-info.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/src/gclue-client-info.c b/src/gclue-client-info.c
>index 6bd7ef5..3e886f6 100644
>--- a/src/gclue-client-info.c
>+++ b/src/gclue-client-info.c
>@@ -256,7 +256,7 @@ gclue_client_info_init_async (GAsyncInitable     *initable,
>         task = g_task_new (initable, cancellable, callback, user_data);
> 
>         g_dbus_proxy_new_for_bus (G_BUS_TYPE_SYSTEM,
>-                                  G_DBUS_PROXY_FLAGS_NONE,
>+                                  G_DBUS_PROXY_FLAGS_DO_NOT_LOAD_PROPERTIES,
>                                   NULL,
>                                   "org.freedesktop.DBus",
>                                   "/org/freedesktop/DBus",
>-- 
>2.5.0

Actions: View | Splinter Review

Attachments on bug 92979: 119733 | 119950

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.