Bug 92979 - GClueClientInfo tries to load properties of system org.freedesktop.DBus
Summary: GClueClientInfo tries to load properties of system org.freedesktop.DBus
Status: RESOLVED FIXED
Alias: None
Product: GeoClue
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Geoclue Bugs
QA Contact: Geoclue Bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-17 09:31 UTC by Tristan Van Berkom
Modified: 2015-11-20 14:27 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Avoid loading properties of org.freedesktop.DBus (1.54 KB, text/plain)
2015-11-17 09:31 UTC, Tristan Van Berkom
Details
client-info: Don't load props of /org/freedesktop/DBus (1.58 KB, patch)
2015-11-19 19:08 UTC, Zeeshan Ali
Details | Splinter Review

Description Tristan Van Berkom 2015-11-17 09:31:44 UTC
Created attachment 119733 [details]
Avoid loading properties of org.freedesktop.DBus

As mentioned in the commit message of the attached patch; GeoClue works fine without this, but this patch will avoid some misleading error messages in the system logs (error messages which are likely to confuse system integrators while trying to integrate geoclue properly).
Comment 1 Zeeshan Ali 2015-11-19 19:08:32 UTC
Created attachment 119950 [details] [review]
client-info: Don't load props of /org/freedesktop/DBus

By default, glib's GDBusProxy calls org.freedesktop.DBus.Properties.GetAll
to load all properties on a loaded interface - however in this case we
are creating a proxy to the system standard bus interface for the sole
purpose of later calling GetConnectionUnixUser.

GeoClue does not have permission to use the org.freedesktop.DBus.Properties
interface on a proxy to /org/freedesktop/DBus (and there are no properties
to be loaded anyway).

Note that GeoClue works fine without this patch, however this patch
will avoid error messages being logged to the system logs.
Comment 2 Zeeshan Ali 2015-11-19 19:09:35 UTC
Comment on attachment 119733 [details]
Avoid loading properties of org.freedesktop.DBus

I fixed/updated the git commit. Please let me know if i instead made it wrong. :)
Comment 3 Tristan Van Berkom 2015-11-20 07:34:43 UTC
Comment on attachment 119950 [details] [review]
client-info: Don't load props of /org/freedesktop/DBus

Review of attachment 119950 [details] [review]:
-----------------------------------------------------------------

Heh,

Of course, your changes to the commit message did not break the proposed one line change :)

Your summary is also more accurate.
Comment 4 Zeeshan Ali 2015-11-20 14:27:07 UTC
Attachment 119950 [details] pushed as 45593fe - client-info: Don't load props of /org/freedesktop/DBus


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.