Attachment 120846 Details for Bug 93605 – [PATCH] module-tunnel: Fix double free, Local pointer 'dn' freed again when pa_thread_new() failed. (upload patch again)

[patch] [PATCH] module-tunnel: Fix double free, Local pointer 'dn' freed again when pa_thread_new() failed. (upload patch again)

0001-module-tunnel-Fix-double-free_again.patch (text/plain), 975 bytes, created by KimJeongYeon on 2016-01-06 23:27:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: KimJeongYeon

Created: 2016-01-06 23:27:43 UTC

Size: 975 bytes

patch

obsolete

>From 02710b70dd3400cb3fc1d22f4fbce52011ab316a Mon Sep 17 00:00:00 2001
>From: KimJeongYeon <jeongyeon.kim@samsung.com>
>Date: Wed, 6 Jan 2016 17:28:11 +0900
>Subject: [PATCH] module-tunnel: Fix double free
>
>Local pointer 'dn' freed again when pa_thread_new() failed.
>
>Signed-off-by: KimJeongYeon <jeongyeon.kim@samsung.com>
>---
> src/modules/module-tunnel.c |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/src/modules/module-tunnel.c b/src/modules/module-tunnel.c
>index 833423a..53c4402 100644
>--- a/src/modules/module-tunnel.c
>+++ b/src/modules/module-tunnel.c
>@@ -2200,8 +2200,6 @@ int pa__init(pa_module*m) {
>     u->mcalign = pa_mcalign_new(pa_frame_size(&u->source->sample_spec));
> #endif
> 
>-    pa_xfree(dn);
>-
>     u->time_event = NULL;
> 
>     u->maxlength = (uint32_t) -1;
>@@ -2222,6 +2220,8 @@ int pa__init(pa_module*m) {
>     pa_source_put(u->source);
> #endif
> 
>+    pa_xfree(dn);
>+
>     if (server)
>         pa_xfree(server);
> 
>-- 
>1.7.9.5
>

Actions: View | Splinter Review

Attachments on bug 93605: 120826 | 120846

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.