Bug 93605 - [PATCH] module-tunnel: Fix double free
Summary: [PATCH] module-tunnel: Fix double free
Status: RESOLVED FIXED
Alias: None
Product: PulseAudio
Classification: Unclassified
Component: modules (show other bugs)
Version: unspecified
Hardware: All All
: medium critical
Assignee: pulseaudio-bugs
QA Contact: pulseaudio-bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-06 08:42 UTC by KimJeongYeon
Modified: 2016-01-07 12:33 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
[PATCH] module-tunnel: Fix double free, Local pointer 'dn' freed again when pa_thread_new() failed. (704 bytes, text/plain)
2016-01-06 08:42 UTC, KimJeongYeon 		Details
[PATCH] module-tunnel: Fix double free, Local pointer 'dn' freed again when pa_thread_new() failed. (upload patch again) (975 bytes, patch)
2016-01-06 23:27 UTC, KimJeongYeon 		Details | Splinter Review
Show Obsolete (1) View All

Description KimJeongYeon 2016-01-06 08:42:44 UTC 
Created attachment 120826 [details]
[PATCH] module-tunnel: Fix double free, Local pointer 'dn' freed again when pa_thread_new() failed.

Dear all,

Local pointer 'dn' freed again when pa_thread_new() failed in module-tunnel.c.
Please find attached patch and review it. Thanks.

Regards,
KimJeongYeon
Comment 1 Arun Raghavan 2016-01-06 10:10:26 UTC 
Thanks for the patch. I think it would be better to just move the pa_xfree(dn) a few lines below to where the other free happens (after the last 'goto fail').
Comment 2 KimJeongYeon 2016-01-06 23:27:43 UTC 
Created attachment 120846 [details] [review]
[PATCH] module-tunnel: Fix double free, Local pointer 'dn' freed again when pa_thread_new() failed. (upload patch again)

Thanks for review. I uploaded the patch again.
Comment 3 Arun Raghavan 2016-01-07 12:33:18 UTC 
Merged, thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.