Attachment 127020 Details for Bug 98089 – Fix double printing function name in _dbus_verbose() messages.

[patch] Fix double printing function name in _dbus_verbose() messages.

Fix-double-printing-function-name-in-dbusverbose-m.patch (text/plain), 1.80 KB, created by Ralf Habacker on 2016-10-05 07:58:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ralf Habacker

Created: 2016-10-05 07:58:38 UTC

Size: 1.80 KB

patch

obsolete

>From 74f65d04c2976cc023b0d5ad4c61ea436558842d Mon Sep 17 00:00:00 2001
>From: Ralf Habacker <ralf.habacker@freenet.de>
>Date: Fri, 20 May 2016 06:30:21 +0200
>Subject: [PATCH] Fix double printing function name in _dbus_verbose()
> messages.
>
>Bug: https://bugs.freedesktop.org/show_bug.cgi?id=98089
>---
> dbus/dbus-sysdeps-util-win.c | 2 +-
> dbus/dbus-sysdeps-win.c      | 2 +-
> dbus/dbus-transport.c        | 6 ++----
> 3 files changed, 4 insertions(+), 6 deletions(-)
>
>diff --git a/dbus/dbus-sysdeps-util-win.c b/dbus/dbus-sysdeps-util-win.c
>index dacb8d2..eb860f4 100644
>--- a/dbus/dbus-sysdeps-util-win.c
>+++ b/dbus/dbus-sysdeps-util-win.c
>@@ -305,7 +305,7 @@ void
> _dbus_set_signal_handler (int               sig,
>                           DBusSignalHandler handler)
> {
>-  _dbus_verbose ("_dbus_set_signal_handler() has to be implemented\n");
>+  _dbus_verbose ("has to be implemented\n");
> }
> 
> /**
>diff --git a/dbus/dbus-sysdeps-win.c b/dbus/dbus-sysdeps-win.c
>index 88fde21..479abff 100644
>--- a/dbus/dbus-sysdeps-win.c
>+++ b/dbus/dbus-sysdeps-win.c
>@@ -507,7 +507,7 @@ _dbus_close_socket (DBusSocket fd,
>                       fd.sock, _dbus_strerror_from_errno ());
>       return FALSE;
>     }
>-  _dbus_verbose ("_dbus_close_socket: socket=%Iu, \n", fd.sock);
>+  _dbus_verbose ("socket=%Iu, \n", fd.sock);
> 
>   return TRUE;
> }
>diff --git a/dbus/dbus-transport.c b/dbus/dbus-transport.c
>index e9a7340..bee57ca 100644
>--- a/dbus/dbus-transport.c
>+++ b/dbus/dbus-transport.c
>@@ -1145,10 +1145,8 @@ _dbus_transport_queue_messages (DBusTransport *transport)
> {
>   DBusDispatchStatus status;
> 
>-#if 0
>-  _dbus_verbose ("_dbus_transport_queue_messages()\n");
>-#endif
>-  
>+  _dbus_verbose ("enter\n");
>+
>   /* Queue any messages */
>   while ((status = _dbus_transport_get_dispatch_status (transport)) == DBUS_DISPATCH_DATA_REMAINS)
>     {
>-- 
>1.8.4.5

Actions: View | Splinter Review

Attachments on bug 98089: 127020 | 127022

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.