Created attachment 127020 [details] [review]
Fix double printing function name in _dbus_verbose() messages.

Comment on attachment 127020 [details] [review]
Fix double printing function name in _dbus_verbose() messages.

Review of attachment 127020 [details] [review]:
-----------------------------------------------------------------

Fine, except that you're introducing verbose logging that wasn't previously there.

::: dbus/dbus-transport.c
@@ +1145,4 @@
>  {
>    DBusDispatchStatus status;
>  
> +  _dbus_verbose ("enter\n");

This was previously #if 0. I suspect this may have been because this function is frequently called, so it was so ridiculously verbose that it makes DBUS_VERBOSE even less useful than it already is?

(In reply to Simon McVittie from comment #2)
> Comment on attachment 127020 [details] [review] [review]
> Fix double printing function name in _dbus_verbose() messages.
> 
> Review of attachment 127020 [details] [review] [review]:
> -----------------------------------------------------------------
> 
> Fine, except that you're introducing verbose logging that wasn't previously
> there.
> 
> ::: dbus/dbus-transport.c
> @@ +1145,4 @@
> >  {
> >    DBusDispatchStatus status;
> >  
> > +  _dbus_verbose ("enter\n");
> 
> This was previously #if 0. I suspect this may have been because this
> function is frequently called, so it was so ridiculously verbose that it
> makes DBUS_VERBOSE even less useful than it already is?

Okay, I will wrap this hunk with #if 0 ...#endif, so that people want to debug cant change that.

Created attachment 127022 [details] [review]
Fix double printing function name in _dbus_verbose() messages.

Bug:

Attachment 127022 [details] pushed as 487a26f - Fix double printing function name in _dbus_verbose() messages.