Attachment 127915 Details for Bug 98685 – Fix

[patch] Fix

0001-Do-not-part-from-channels-in-destroy-handler.patch (text/plain), 1.03 KB, created by Daniel Landau on 2016-11-11 13:37:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Landau

Created: 2016-11-11 13:37:36 UTC

Size: 1.03 KB

patch

obsolete

>From b3fe01ca224c35647e34d49d5dac70c126a0d7c6 Mon Sep 17 00:00:00 2001
>From: Daniel Landau <daniel@landau.fi>
>Date: Sat, 27 Aug 2016 19:36:16 +0300
>Subject: [PATCH 1/3] Do not part from channels in destroy handler
>
>In case the client suddenly disappears (e.g. crashes) the user was
>previously parted from the channels. This is terrible behaviour when the
>user is using a bouncer, as they expect to stay in their channels. This
>handler doesn't seem to be called on clean exit of clients, only when
>they disappear suddenly.
>---
> src/idle-muc-channel.c | 3 ---
> 1 file changed, 3 deletions(-)
>
>diff --git a/src/idle-muc-channel.c b/src/idle-muc-channel.c
>index c335efa..ab40dbb 100644
>--- a/src/idle-muc-channel.c
>+++ b/src/idle-muc-channel.c
>@@ -1355,9 +1355,6 @@ idle_muc_channel_destroy (
> 
> 	IDLE_DEBUG ("called on %p", self);
> 
>-	if (priv->state == MUC_STATE_JOINED)
>-		part_from_channel (self, NULL);
>-
> 	/* FIXME: this is wrong if called while JOIN is in flight. */
> 	if (priv->state < MUC_STATE_JOINED)
> 		tp_base_channel_destroyed (base);
>-- 
>2.10.2
>

Actions: View | Splinter Review

Attachments on bug 98685: 127915

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.